Justin• 300
@iamprincetj
Submitted
Sunil
@SunilParbhoo
All comments
- Sunil• 130
@SunilParbhoo
Posted
Nice job on this project. One thing I think you could try in order to reduce redundancy in your css code is to set the border radius on just your
.containerclass, remove the additionalborder top left radius: .07em;and theborder bottom left radius: .07em;on theimg-container. Instead addoverflow:hiddento the.containerclass. This should reduce some lines of code and still produce the desired effect.Marked as helpful
0 What are you most proud of, and what would you do differently next time?
Reading about semantic HTML :) Made me rethink how often I reach for div all the time.
What challenges did you encounter, and how did you overcome them?
Thinking of how to include a heading or similar in each article or section, but found this comes naturally after a while.
What specific areas of your project would you like help with?
I've read the MDN docs, and my take home understanding is is used for something "standalone" and/or reusable. is more for highlighting a non-standalone area or group of items (or basically when a more specific element isn't available). is use purely when styling needs to be added to a block. I'd be grateful for any mental models people have found helpful for when to use one or the other.
Sunil• 130@SunilParbhoo
Posted
Nice job on this project! Nice job utilizing html elements other than divs for everything. To address your question regarding possible additional elements to use other than divs, here is an article that may be useful (although I see you already read through the MDN docs for this as well). Stop using so many divs! An intro to semantic HTML
One thing to possibly get this to look more closer to the design is to make sure you are using the correct font color for the text. Other than that, keep up the good work!
Marked as helpful
1- Dirk• 210
@dirkvankrieken
Submitted
Sunil• 130@SunilParbhoo
Posted
Hello Dirk, I like your solution to the challenge, and like how you organized your code. Your use of CSS variables is great for reusability. One suggestion may be to possibly provide space between your attribution and the main content, but of course this design choice may be considered subjective. Congratulations on completing this challenge and happy coding!
0 @Gautamy201
Submitted
What are you most proud of, and what would you do differently next time?
Reflecting on my recent projects, I'm most proud of the seamless integration of various frontend technologies like HTML & CSS
Sunil• 130@SunilParbhoo
Posted
Hey there, nice job on this! A suggestion may be that in mobile size, possibly add a little padding or margin to the sides of blog-card so that there is some space between the card and the body. I like your use of CSS variables for reusability and your use of the transition property to smooth the hover state on the button.
0- quypq147• 150
@quypq147
Submitted
Sunil• 130@SunilParbhoo
Posted
Hello, nice job! I believe you may have forgotten to utilize the correct font family and font weights that were listed in the style-guide.md file that was included with the project starter files. Overall I think you did well! Happy coding!
Marked as helpful
0
