Skip to content
OverviewSolutions
4
Comments
2
Diego De Tomás
@SrCienpies

All comments

  • Diego De Tomás•55
    @SrCienpiesPosted over 3 years ago

    Amazing job! I love it. Just a detail about the Dark mode change, i feel is kind of abrupt change, maybe with a slower transition could be more pleasant.

    0
  • Lynette Lopez•30
    @lynettelopezSubmitted over 3 years ago

    I implemented the suggestions left on my last challenge: declared decorative images as background-image(s) rather than in HTML tags, used semantic HTML5 structural elements, and (tried to) use more heading elements.

    However, getting the orange floating box to appear on top of the component while declared as a background-image was tricky. Eventually, I just decided to remove it from my CSS and use an img tag instead.

    FAQ Accordion Card ft. SCSS

    3
    Diego De Tomás•55
    @SrCienpiesPosted over 3 years ago

    I really like the animation of the floating box. In my case i try not to use background images when is not a background, instead i use a normal tag img and add the content via css. Just one issue when display the web on Google Chrome Mobile device the image go outside the top of the page, but the rest great job!

    1