@HeadfranSubmitted over 2 years ago
Hi, this is the first landing page I made. I will appreciate any feedback you can offer me.
remsB
@SonalptAll comments
- @SonalptPosted over 2 years ago
Hi there ! First of all, I have to tell you that you did an amazing job on this. The model is well respected, and the website is pretty responsive. The global layout is well designed, even the hamburger menu when we click on it !
For the HTML and accessibility issues, here's some tips :
-
Don't forget to add "aria-label" attributes to all "a" tags, with a good description to know where the redirection... redirect, ahah, to make it more accessible.
-
Be careful, you have 2 footers in your code. the one you've created, and the one amready included in the code, when you download it.
Have a nice journey on FrontendMentors !
0 -
- @Babaneh1001Submitted over 2 years ago
Thank you guys for taking time to review my project, I wanted to just confess off the bat I couldn't implement the dropdown on the mobile side of things
I realized I have a lot more work to do on creating my navigation, took me a lot of time to get it to work. Patches here and there.
I'm glad I was able to get this far might someday come back to finish it
@SonalptPosted over 2 years agoHi there ! To complete previous comments, and just to add some aesthetic details, don't forget to :
- Add the :hover effect "pointer" on your differents elements on the nav bar, to make it looks more professional.
- When you hover "register" button, his size change and make the navigation bar move a little bit. It's nothing, but you can fix this really easily !
I just wanted to comment on details because, except that, your work is really responsive, and the desktop layout is pretty minimalist and cool, you did it great !
0 - @larissamsantosSubmitted about 3 years ago@SonalptPosted about 3 years ago
Hi !
I don't if you are publishing this project in that state to get some solutions in comments, but, actually, your website is not centered, not responsive, and the vehicle's images don't load !
Maybe the wrong version in GitHub ? Or you simply need some help !
0 - @Duyen-codesSubmitted about 3 years ago@SonalptPosted about 3 years ago
Hi ! First of all, great job on this ! I didn't checked your code yet, just the website, and his responsive version.
For now, my only comment for you is that your button's sizes, in their hover states, automatically increase, and it don't looks very smooth. Maybe it's just a design choice from you, but anyway, just wanted to notice about that.
Sorry for my english, i'm french and i'm actually learning ahah.
Marked as helpful0 - @SonalptSubmitted about 3 years ago
I had a problem with the "Annual Plan" section. I've tried everything, with text align, justify content or align items, but i can't align "Annual" and "Plan" on the same line. i know its probably an oversight but, can't find, and i need some help !
thx in advance !
