Intro-section-with-dropdown-navigation
Design comparison
Solution retrospective
Thank you guys for taking time to review my project, I wanted to just confess off the bat I couldn't implement the dropdown on the mobile side of things
I realized I have a lot more work to do on creating my navigation, took me a lot of time to get it to work. Patches here and there.
I'm glad I was able to get this far might someday come back to finish it
Community feedback
- @SamadeenPosted over 2 years ago
Hey Omo Iya Mii!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should use <main class="section"> instead of <div class="section">.
- You can wrap your attribution section in a footer tag to avoid accessibility issues.
- You should not nest a button in an ol or ul..
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
1@Babaneh1001Posted over 2 years ago@Samadeen Thank you so much broski
yeah this challenge let me know say I still need to improve on my navigation menu
0@SamadeenPosted over 2 years ago@Babaneh1001 You fit check my own make you see as i run am
1 - @SonalptPosted over 2 years ago
Hi there ! To complete previous comments, and just to add some aesthetic details, don't forget to :
- Add the :hover effect "pointer" on your differents elements on the nav bar, to make it looks more professional.
- When you hover "register" button, his size change and make the navigation bar move a little bit. It's nothing, but you can fix this really easily !
I just wanted to comment on details because, except that, your work is really responsive, and the desktop layout is pretty minimalist and cool, you did it great !
0@Babaneh1001Posted over 2 years ago@Sonalpt thank you so much The hover effects were kinda confusing but I'll look into understanding how to implement hover effects in newer projects
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord