Accel-exe• 170
@Accel-exe
Submitted
Simone-cpu-debug
@Simone-cpu-debug
All comments
- Simone-cpu-debug• 120
@Simone-cpu-debug
Posted
It's not centered tho, anything beside that it's good
0 - duongns-vn• 210
@duongns-vn
Submitted
What are you most proud of, and what would you do differently next time?
I was hesitant to choose between Flexbox and Grid to responsive for 4 cards. In the end I decided to choose Grid with grid-templete-areas property, because I thought maybe it would help more and faster than flexbox in this case.
Simone-cpu-debug• 120@Simone-cpu-debug
Posted
Honestly very good code, very close to it's original, I supposed you used figma too to view the proportions.
1 - Hajar Wahid• 190
@hajar-wa
Submitted
What are you most proud of, and what would you do differently next time?
I enjoyed coding this project, I learnt how to select an updated value of viewport width and manipulate the DOM. next time, I want to use REACT.
If you have any feedback and how can I improve this project please comment below :)
Simone-cpu-debug• 120@Simone-cpu-debug
Posted
A little bit more padding is good, also imo in the html is not very semantic. I don't think you should use react for small projects like this one, maybe scss but nothing besides that.
0 - Ali Ayad• 60
@ali-ayad
Submitted
What are you most proud of, and what would you do differently next time?
will add some animation
Simone-cpu-debug• 120@Simone-cpu-debug
Posted
It's very good, very close to the original. But I don't understand the css tho.
0 - Wanjiku Ngaruiya• 70
@Shikonga
Submitted
Simone-cpu-debug• 120@Simone-cpu-debug
Posted
try to include all the elements in a div with a class
Marked as helpful
0 - Vasavi Dwivedi• 80
@vvvasavii
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of how easily i was able to use flexbox this time since last time it was a bit tough for me. Next time,i would try to not procrastinate and complete my challenges early.
What challenges did you encounter, and how did you overcome them?
Was stuck for a solid 5 min trying to lift the greg hooper text up a bit because the avatar was also changing position along with it. Overcame it by giving it a thought and applying the flexbox property indivuially to the element.
What specific areas of your project would you like help with?
Pls review my code if you happen to have some spare time and point out any mistakes or useless pieces of code. I really look forward to feedbacks,negative or positive :)
Simone-cpu-debug• 120@Simone-cpu-debug
Posted
next time when you build a card, try to not give a fixed width, or if you use it, give it a max-width too. but try to play with max-width as it's more responsive. and also, add some semantic html, like give the img a class of "card_image" and all the texts a class of "card_text", it will be easier and safer imo
0
