Abhi• 220
@abhi-zero
Submitted
Edith
@ShiRaw11
All comments
- Edith• 50
@ShiRaw11
Posted
Looks good: Some suggestions include:
- Have some padding on the class - buttons.
- Have the css folder independently, not inside the assets(for better accessibility).
Marked as helpful
0 - Raltss• 20
@Raltss
Submitted
Edith• 50@ShiRaw11
Posted
- Your card/ container does not have a hover effect for increasing the box shadow and changing the text color.
- Please have your css file in its own folder or where index.html is, not in the design folder.
- The alt in the image should be descriptive, not empty.
- Have a line height for the paragraph so that the lines are not so close together.
0 - LunaHeuguerot• 10
@LunaHeuguerot
Submitted
Edith• 50@ShiRaw11
Posted
Some few suggestions for improvement: Wrap the content in a landmark like a main tag. Have styles to center your container in the body instead of having a margin top. Have some padding on the container. Otherwise looks good!.
0 - AmateurShark• 10
@AmateurShark
Submitted
What are you most proud of, and what would you do differently next time?
I'm most proud of being able to build this from scratch without external libraries or looking at other projects I already made. I figured out how to use flexbox here (with the help of a cheat sheet).
Next time I would place a little more focus on making this a responsive page, as well as committing to using flexbox from the beginning.
What challenges did you encounter, and how did you overcome them?
I'm still struggling to understand overflow in the context of margins and padding. It took me a lot of trial and error in the development tools to see which object in the body was the culprit for the warning message.
What specific areas of your project would you like help with?
I was quite unsure about how to achieve the right font sizing, I ended up using rems for the headline.
Edith• 50@ShiRaw11
Posted
Your code looks good and meets the required layout and functionality! It also almost aligns well with the design which is impressive. One suggestion for improvement would be to wrap your content in a landmark.
1
