Skip to content
OverviewSolutions
5
Comments
2
Shayne Geilman
@ShayneJG

All comments

  • Shayne Geilman•160
    @ShayneJGPosted about 1 year ago

    Hey Ahmed :)

    Good job on the challenge!

    I really love the mouse over effects you have on the desktop menu. The transition looks really good.

    Some things to consider:

    • Elements on page are too large on 1440p monitors. Consider adding a max width/height.

    • There is an uncaught TypeError if you click the image in mobile view. You might need to find a way to check whether or not the image is being viewed at a certain screen size.

    • The borders of your thumbnail images are also being affected by the opacity. You can avoid this by putting the image in a <div> and then setting the border on the div instead.

    • The design images suggest that the thumbnails should have some white colour show through on hover and selection. This works because you have a white background on the main page, but in the lightbox view, it shows them as dimmer because of the darker background. Adding a white background to a <div> is a workaround to this.

    Keep up the good work :)

    Marked as helpful
    1
  • Shayne Geilman•160
    @ShayneJGPosted about 1 year ago

    Good job Bisola :),

    A couple things to investigate:

    The background and the cards responsively shrink differently. It could be worth making the cards reposition in a manner similar to the background, i.e., as the screen gets smaller, the cards move over as the purple area shrinks to maintain the aesthetic. It also does not maintain the same design at 1440p, which could be worth addressing :).

    If you look at the DevTools of your chosen browser, you may see that you have some duplicate IDs that need addressing as well for the form to function effectively. Duplicate IDs will block the autofill from completing correctly.

    Marked as helpful
    1