Mustafa Khaled• 20
@aty101
Submitted
Sean H
@Sean-LH
All comments
- Sean H• 90
@Sean-LH
Posted
Currently I can't think of anything I would change about this project.
0 - Pchelsea-here• 140
@chelsea-here
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of my react component and my first incorporation of sass.
What challenges did you encounter, and how did you overcome them?
I had a hard time getting the component to work correctly for both typescript and react. I'm glad I was able to figure it out!
What specific areas of your project would you like help with?
Any advice on best practices, writing clean code or where to break items up into components is welcome. Cheers!
Sean H• 90@Sean-LH
Posted
This project looks fantastic. No notes
0 - Nick• 30
@NickTalvy
Submitted
I found it difficult to get my padding correct for the text. Also, I attempted MQ for tablet and desktop. I feel like I made it harder or more complicated then it needed to be.
I tried to keep accessibility in mind. Please tell me what I could do better, or any best practices I missed.
Sean H• 90@Sean-LH
Posted
Hey @NickTalvy,
Awesome work on finishing the project, despite the challenges you had.
In the future I would recommend starting with the mobile design first. I find it to be simpler to manage things like spacing when the viewport is smaller. And things get more complex as you increase the viewport. With that said, you may only have to do one MQ instead of two when you're expanding the viewport in the future.
Marked as helpful
1
