Skip to content
OverviewSolutions
10
Comments
10
P
SaeedAbakah
@SaeedAbakah

All comments

  • percydocomo•520
    @percydocomoSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    Using JavaScript to perform simple email validation. Maybe it's not the best solution to use visibility to display or dismiss an element, so I would try something else next time.

    What challenges did you encounter, and how did you overcome them?

    Positioning the list icon with the list content. I used 'background-image' instead of 'list-style-image' and positioned the icon with 'background-position'.

    What specific areas of your project would you like help with?

    All feedback is welcome.

    Newsletter sign-up form with success message

    1
    P
    SaeedAbakah•140
    @SaeedAbakahPosted 3 months ago

    Neat and very readable code. Well done! I'm not sure if its by design or not but screen <=950px, there's a lot of margin around your content

    0
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 4 months ago

    Good build buddy. I'm unable to understand the comments in our code but heres what i noticed; On smaller screens, your pop-up socials dont toggle display so have a look at it.

    1
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 4 months ago

    Very good build and kudos for using a framework. I guess it makes the job easier. Just a couple things to note;

    1. Do you mean to keep those border lines on the page or is it an oversight?
    2. At breakpoints of 1024px - 768px, the hero images didnt seem to be displayed on the website. Kindly look into that
    0
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 5 months ago

    clean, simple and sustainable code

    0
  • Pickle•220
    @Augurk66Submitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    This is the first time that I used grid in a project. I am proud of the fact that I accomplished this assignment.

    What challenges did you encounter, and how did you overcome them?

    Setting up grid for bigger screen. I checked some videos and some websites to center the left and right blocks.

    What specific areas of your project would you like help with?

    Working with sizing the page content. The content doesn't fit within a browser page.

    Four card section using grid

    1
    P
    SaeedAbakah•140
    @SaeedAbakahPosted 5 months ago

    very good build. Cant fault it!

    0
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 5 months ago

    very good build. clean code and very good use of clamp() for responsive typo

    0
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 5 months ago

    very good build. look at the color for the hero title

    Marked as helpful
    0
  • Naveen K•50
    @naveenkkannanSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I was able to nearly perfect the design without a Figma file.

    What challenges did you encounter, and how did you overcome them?

    Without a Figma file, it was challenging to accurately measure the margins and padding.

    What specific areas of your project would you like help with?

    I would appreciate your help in verifying whether the font size and weight are appropriate.

    Social Links Profile

    1
    P
    SaeedAbakah•140
    @SaeedAbakahPosted 5 months ago

    Good efforts. Check the title of your index.html, i think you need to get rid of the "<h1>" there. Also instead of using individual divs, I think its more useful to use a <ul> to nest all the links and dont forget to add the <a> tag to make them a true link. hope it helps

    0
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 6 months ago

    Very good build, properly structured and reusable code.Well done!

    1
  • P
    SaeedAbakah•140
    @SaeedAbakahPosted 6 months ago

    cool build but consider responsiveness

    0