Skip to content
OverviewSolutions
12
Comments
5
Sador
@SadorDev

All comments

  • Sador•200
    @SadorDevPosted 2 months ago

    Hi, Well done on completing this. It's a very beginner-friendly project, so I hope you didn't find it difficult. Starting out can be overwhelming for everyone, but with practice, that feeling can transform into a strong work ethic if you're disciplined and focused. To improve, ensure you understand what Semantic HTML is. Have a read through https://www.codecademy.com/learn/learn-html/modules/learn-semantic-html/cheatsheet Avoid using pixels for font sizes to follow good accessibility practices. Be familiar with the various CSS units, this will be handy for future projects you build that require a mobile first approach and responsiveness. Don't overwhelm yourself with the things I've mentioned here. Take it slow and continue building, its the best way to learn. Good luck and well done on completing this challenge 👏🏾

    0
  • Sador•200
    @SadorDevPosted 12 months ago

    Hi I haven’t managed to look at it on desktop but it’s not working on mobile I just tried to on my phone and the dice wasn’t clickable

    1
  • Sador•200
    @SadorDevPosted 12 months ago

    Hi there, Good job on completing this challenge.

    I've just completed this challenge also. Thought I'd share some things

    1. Use semantic HTML rather than divs to make it more reader-able
    2. Currently, your intro-container takes up a large portion of all screens. I would suggest re-doing your media queries as you've added 3 too many https://css-tricks.com/a-complete-guide-to-css-media-queries/ Is a good article. Have a play around with some shapes and get a feel of knowing what's doing what. Don't stress yourself over this😄 Have fun with it

    Happy Coding👋🏾

    Marked as helpful
    0
  • Sador•200
    @SadorDevPosted about 1 year ago

    You might want to consider getting rid of your height to bring it closer to the design. Good job overall👍🏾

    0
  • Majd Allaham•120
    @Vat123Submitted almost 2 years ago

    i did this challenge Responsive Card with flex and grid , Any comment to improve would be welcomed !!

    Responsive Card

    1
    Sador•200
    @SadorDevPosted almost 2 years ago

    Good job completing the challenge.

    I don't think you've correctly added the font family "Fraunces", serif" which is why the font doesn't look the way it should. If you have a look at mine, you'll notice the difference in font.

    Keep your class names consistent in your mark-up. When working in a team, other devs want to have an easy to follow line of code when working on a project. Try to add comments in your CSS to indicate what's what. For this challenge, you have kept it consistent but just bear it in mind.

    Before submitting your code, have a look through your code to check things. I noticed at the bottom of the mark-up you have commented out lines of code. This is isn't good practice. You want you code to be clean and easily readable.

    But good job completing the challenge👍🏾✨

    Marked as helpful
    0