Design comparison
Solution retrospective
i did this challenge Responsive Card with flex and grid , Any comment to improve would be welcomed !!
Community feedback
- @SadorDevPosted over 1 year ago
Good job completing the challenge.
I don't think you've correctly added the font family "Fraunces", serif" which is why the font doesn't look the way it should. If you have a look at mine, you'll notice the difference in font.
Keep your class names consistent in your mark-up. When working in a team, other devs want to have an easy to follow line of code when working on a project. Try to add comments in your CSS to indicate what's what. For this challenge, you have kept it consistent but just bear it in mind.
Before submitting your code, have a look through your code to check things. I noticed at the bottom of the mark-up you have commented out lines of code. This is isn't good practice. You want you code to be clean and easily readable.
But good job completing the challenge👍🏾✨
Marked as helpful0@Vat123Posted over 1 year ago@SadorDev thank you ,yea i totally forgot about the comments in the html section and for sure i will start to add comments for CSS file to make it easier for the others to understand what i did .
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord