Skip to content
OverviewSolutions
2
Comments
3
Rostyk Lukavyi
@RostykL

All comments

  • MD Salahuddin•150
    @mdsalahuddin2001Submitted almost 4 years ago

    Hey Gyz, I have completed fylo-dark-theme challenge . I am hunker after your valuable feedback. Please suggest me where I need to improve. Your feedback is like a gem to me.

    Fylo Dark Theme

    3
    Rostyk Lukavyi•70
    @RostykLPosted almost 4 years ago

    Hi, It looks nice but the block with the title "Access your files, anywhere" is a little bit higher then it should be.

    1
  • Rostyk Lukavyi•70
    @RostykLPosted almost 4 years ago

    Hello, It looks really nice. If you click the country and the see the "Border Countries" there you have a few countries and their height are sometimes bigger than it should be, I think it should wrap the word but it shouldn't leave an empty space in the bottom as you have Overall it looks nice, you can try to add a filter system or probably make a search by capital.

    0
  • Jason•120
    @jasonalnerSubmitted almost 4 years ago

    Completed using html, css and javascript. First project completed with javascript, researching and adapting code from multiple sources. Any feedback most welcome!

    FAQ Accordion using html, css and JavaScript

    2
    Rostyk Lukavyi•70
    @RostykLPosted almost 4 years ago

    Hello, Learn about flex-box or CSS-grid. I didn't look at the code fully but I see that you used position absolute with the top property of 60% it's a bad practice since if you open it on Ipad Pro it goes down and I can't see the whole block. You can easily center a block using these three properties: display: flex; align-items: center; justify-content: center;

    Also, you don't have a tablet version of your website. It goes from desktop to mobile but should go from desktop -> tablet -> mobile You should learn more about responsive design.

    Overall you did well, I also did and do many mistakes when I do PSD to HTML but we are learning and that's ok.

    1