FAQ Accordion using html, css and JavaScript

Community feedback

• 

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  Hi Jason 👋🏻.Well done. 👏 This challenge is a bit tricky, and I like the way how you approached it.

  Just a humble suggestion. 😊

  • Mobile version, doesn't look good, the card looks cut. Try to fix it.

  • If it had to position the card I would use flex-box rather than position fixed.@media (min-width: 1200px).flex-container

  • It would be much better if you use just classes in your CSS.

  Happy Coding 🧑‍💻

  2

  ---

  

  Jason•120

  @jasonalnerPosted almost 4 years ago

  @RenszCamacho thanks Rensz!! I’ll take your suggestions on board and attempt it again soon. Thank you for your feedback and encouragement!

  0
• 

  Rostyk Lukavyi•70

  @RostykLPosted almost 4 years ago

  Hello, Learn about flex-box or CSS-grid. I didn't look at the code fully but I see that you used position absolute with the top property of 60% it's a bad practice since if you open it on Ipad Pro it goes down and I can't see the whole block. You can easily center a block using these three properties: display: flex; align-items: center; justify-content: center;

  Also, you don't have a tablet version of your website. It goes from desktop to mobile but should go from desktop -> tablet -> mobile You should learn more about responsive design.

  Overall you did well, I also did and do many mistakes when I do PSD to HTML but we are learning and that's ok.

  1

  ---

  

  Jason•120

  @jasonalnerPosted almost 4 years ago

  @RostykL Thanks so much for your feedback Rostyk, I have read a lot about flexbox but not used it in a project yet, so I will make sure I do in the next challenge. I really appreciate your comments.

  0