Skip to content
OverviewSolutions
5
Comments
5
P
Robert Forbes
@RoboticDinosaur

All comments

  • Petrakowww•120
    @PetrakoowSubmitted about 1 month ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of achieving a clean and responsive design that closely resembles the original project requirements. The implementation of the BEM methodology helped me maintain organized and readable code.

    Next time, I would focus more on optimizing my media queries for better performance across different devices and possibly explore more advanced SCSS features to enhance the styling process further.

    Responsive card built with HTML5, SCSS, BEM methodology, Mobile-first.

    1
    Robert Forbes•70
    @RoboticDinosaurPosted about 1 month ago

    Clean code, class names and SCSS. Good job

    0
  • Robert Forbes•70
    @RoboticDinosaurPosted about 1 month ago

    I’m not familiar with the framework while still being a newbie, so I can't assess the code thoroughly. From a design perspective, there are some differences between the final product and the original design, such as spacing around 'Nutrition,' border radii, tab indentations, font weights, and padding, etc. These are relatively simple adjustments that could significantly enhance the overall look and feel of the implementation.

    1
  • Robert Forbes•70
    @RoboticDinosaurPosted about 1 month ago

    The use of semantic HTML elements is good and makes the code clear to read, as does the CSS and use of variables. However, this doesn't follow the responsiveness required by the challenge. A simple media query to adjust the padding would make this great.

    Additionally, the social buttons should probably be using the <a> element instead of <button> as they are navigational links and would improve the semantics and accessibility of the project.

    0
  • Robert Forbes•70
    @RoboticDinosaurPosted about 1 month ago

    The code is well structured with clear class names, which helps with readability. I like the use of semantic HTML elements, like the use of <article>. However, there is a downside, which is it not being response. It doesn't adjust correctly for mobile, which is required with different widths and font sizes on mobile devices. Addressing this will make this an excellent demo.

    0
  • Robert Forbes•70
    @RoboticDinosaurPosted about 1 month ago

    Neat and semantic HTML. Looks good across resolutions.

    Marked as helpful
    0