All comments

• 

  Rasmus•90

  @RaswebSubmitted 10 months ago

  Hello people.

  As this is the first time I'm coding in Angular I would like some tips with the Angular code and also any other tips or other stuff.

  Greate regards, Rasweb.

  

  Frontend Mentor Newsletter sign-up form Using Angular

  1

  10
  

  Rasmus•90

  @RaswebPosted 10 months ago

  I noticed the size difference in the screenshot.

  0
• 

  Gonzalo Orsi•60

  @gonzaloorsiSubmitted 11 months ago

  Hello everyone, and thank you for checking out the rating component! Feel free to explore and interact with it. If you enjoy your experience, I'd love to see your ratings and thoughts in the comments section. All the best! Gon

  

  Interactive Rating Component with Vanilla JavaScript

  1

  40
  

  Rasmus•90

  @RaswebPosted 11 months ago

  Great work. Looks really good.

  I Would just like to point out that your font size could be a little bigger for the accessibility. Because now it may be difficult to read.

  Maybe next time you can try creating different branches on github for practice. I usually do like this: main

  • develop
    • feature/.....

  Like an example. But you may already know this.

  Anyways great job.

  1
• 

  Denys•100

  @DenysmakSubmitted over 2 years ago

  Hardtime

  • I had a hard time spacing the numbers/buttons.

  Unsure -When you haven't chosen any numbers and you click submit, the name undefined appears in the place where the number should be. -When we hover over the number/button which we clicked, the color changes, when it should keep being orange. -Could't figure out how to fix these 2 things

  

  HTML, CSS and Javascript

  2

  30
  

  Rasmus•90

  @RaswebPosted over 2 years ago

  Hello great job!

  Remember there are different solutions for this because JavaScript is amazing but here are some exampels. About the undefined when you haven't choosen a number you could do a for loop to fix it. Like this:

  submit.addEventListener("click", () => { if (number > 0) { // Code if number is higher than 0. } else { // Code if no number is choosen. It could be a simple alert message. } });

  For the button color problem: You can read more about it here: You could try doing a specific for hover and focus: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus https://www.w3schools.com/cssref/sel_focus.asp

  button:hover{ color: black }

  button:focus{ color:black }

  Hope this helps, and great work! Happy coding :)

  Marked as helpful

  1

  This comment has received 2 repliesShow
• 

  Sadman Chowdhury Fahim•220

  @FahimEchoSubmitted over 2 years ago

  

  Responsive Landing page Using CSS Grid

  1

  60
  

  Rasmus•90

  @RaswebPosted over 2 years ago

  Consider adding more to the ReadMe file, like what you used to build the solution with.

  Otherwise a good job, and you have no Accessibility issues or html issues which is great.

  0
• 

  ChechaGon•70

  @chechin2000Submitted over 2 years ago

  I am new at this.

  Any advice would be very helpful, thanks 👏

  

  Interactive rating component

  1

  60
  

  Rasmus•90

  @RaswebPosted over 2 years ago

  Consider adding a ReadMe file it could be about:

  • The project
  • Screenshots of the design.
  • Links you used for help.
  • What you built it with, eg HTML5

  Otherwise good work and happy coding.

  Marked as helpful

  0
• 

  zoolafps•30

  @zoolafpsSubmitted over 2 years ago

  

  interactive-rating-component

  1

  40
  

  Rasmus•90

  @RaswebPosted over 2 years ago

  Your solution is great but when I hover over a rating it is supposed to be orange. On your "View code" link it takes the user to the main branch but your code is on the dev-1 branch. Consider merging the code to Main when you are done. So it's easier to view the code and so you can compare the design on Frontend Mentor.

  Besides good job there, excellent design. Happy coding.

  Marked as helpful

  0