Skip to content
OverviewSolutions
2
Comments
6

Rasmus

@RaswebSweden90 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

Latest comments

  • Rasmus•90
    @RaswebPosted about 1 year ago

    I noticed the size difference in the screenshot.

    0
  • Rasmus•90
    @RaswebPosted about 1 year ago

    Great work. Looks really good.

    I Would just like to point out that your font size could be a little bigger for the accessibility. Because now it may be difficult to read.

    Maybe next time you can try creating different branches on github for practice. I usually do like this: main

    • develop
      • feature/.....

    Like an example. But you may already know this.

    Anyways great job.

    1
  • Rasmus•90
    @RaswebPosted almost 3 years ago

    Hello great job!

    Remember there are different solutions for this because JavaScript is amazing but here are some exampels. About the undefined when you haven't choosen a number you could do a for loop to fix it. Like this:

    submit.addEventListener("click", () => { if (number > 0) { // Code if number is higher than 0. } else { // Code if no number is choosen. It could be a simple alert message. } });

    For the button color problem: You can read more about it here: You could try doing a specific for hover and focus: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus https://www.w3schools.com/cssref/sel_focus.asp

    button:hover{ color: black }

    button:focus{ color:black }

    Hope this helps, and great work! Happy coding :)

    Marked as helpful
    1
  • Rasmus•90
    @RaswebPosted almost 3 years ago

    Consider adding more to the ReadMe file, like what you used to build the solution with.

    Otherwise a good job, and you have no Accessibility issues or html issues which is great.

    0
  • Rasmus•90
    @RaswebPosted almost 3 years ago

    Consider adding a ReadMe file it could be about:

    • The project
    • Screenshots of the design.
    • Links you used for help.
    • What you built it with, eg HTML5

    Otherwise good work and happy coding.

    Marked as helpful
    0
  • Rasmus•90
    @RaswebPosted almost 3 years ago

    Your solution is great but when I hover over a rating it is supposed to be orange. On your "View code" link it takes the user to the main branch but your code is on the dev-1 branch. Consider merging the code to Main when you are done. So it's easier to view the code and so you can compare the design on Frontend Mentor.

    Besides good job there, excellent design. Happy coding.

    Marked as helpful
    0