Skip to content
OverviewSolutions
11
Comments
8
Rashwan-Mohamed
@Rashwan-Mohamed

All comments

  • Rashwan-Mohamed•340
    @Rashwan-MohamedPosted over 1 year ago

    I think that there is a problem with the deploying since the images switcher works fine on my local host !

    0
  • Anderson Vianna•240
    @andykallianSubmitted about 2 years ago

    Hello there!

    well, that one really was a good way to practice how to consuming an API. I decided to upload Json file in Amazon Web Server and use it with FECTH as we do with an API.

    Besides that, i was able to use for first time grid layout in a project. Before that, all i knew about grid layout was theoretical. And I'm still learning it!

    I guess the result are good. BUT, there are 2 things I would like some sugestions

    first one: I sense that in "addEventListenner" i could have used some loop in it. The question is: how?

    second one: In grid css, how can I set a fixed width in the squares (cause when renderizing new data, the square's width seems to adapt and i don't want it. I want a fixed width.

    any suggestion?

    in time, regards and I hope you all enjoy it!

    Time Tracking Dashboard

    3
    Rashwan-Mohamed•340
    @Rashwan-MohamedPosted about 2 years ago

    Hello Anderson , well done finishing the project, just continue to increase you skills since its the only way to do so, I've gone through your Js logic and I see although the approach is working isn't a good practice, I would urge you to go to the solutions and pick an expert solution and examine his js file, regarding the fixed grid column you wouldn't use a grid area in this case, if you want a fixed width for the column you would use something like this grid-templete-columns:40px 40px 40px, more important that this the js logic make sure it never has a lot of repeating lines, don't continue just search for a better approach, there is a YouTube channel with the name of code addict this man creates a lot of projects using js I would recommend it, best luck (:

    0
  • Amir•220
    @amirintechSubmitted over 2 years ago

    This app was great for me to practice basic react features and get used to the JSX syntax, as I am new to react. I am not really sure about the routing system that I have built. Probably, it could be improved.

    Any feedbacks or thoughts would be much appreciated :)

    Responsive entertainment app using react

    1
    Rashwan-Mohamed•340
    @Rashwan-MohamedPosted over 2 years ago

    good job Amir your app is amazing, I see there is an issue with tablet and phone version, the images disappear I think It's a small bug needs to fixed, also I would urge you to take a look at accessibility issues and try to improve them next time, also the bookmarking button I'm not sure if it's needed to be highlighted when pressed or not but it would be nice to make it so, however you made it pixel perfect and once again good job (:

    Marked as helpful
    1
  • Abdul Samad•150
    @abdulsamad2Submitted over 2 years ago

    Completed This challenge by using tailwind-CSS and Vanilla js

    Responsive

    1
    Rashwan-Mohamed•340
    @Rashwan-MohamedPosted over 2 years ago

    Hello Abdul Samad, good job completing the project! I see the site needs some troubleshooting for responsiveness and other features , I would recommend using dev tools I see what's not properly sized and give it a proper sizing, also as the screen gets smaller the font size needs to get smaller also, whether for the headers or whatever..

    Marked as helpful
    0
  • Eileen dangelo•1,600
    @EileenpkSubmitted over 2 years ago

    This challenge took me 6.5 hours to complete from start to finish. (I'm starting to keep track of how long these take me : ) I was able to complete the bonus and add all the info dynamically from the JSON file. If anyone knows of a more dry way to get the current day to equal the value of the weekday please let me know! I used a switch statement in the end.

    Expenses chart component made with Flexbox, Vanilla JavaScript, Fetch

    3
    Rashwan-Mohamed•340
    @Rashwan-MohamedPosted over 2 years ago

    Hello Eileen, your solution is great good job, I think there is a better way for selecting the current day, it would begin by setting data-id for each day in html, then when you get the current day as number you will dynamically select the corresponding data-set id, in html for each day put data-id=(corresponding number), to access it in JS select dataset.id=currentDay, I hope you it clear enough..

    Marked as helpful
    0
  • Rashwan-Mohamed•340
    @Rashwan-MohamedPosted over 2 years ago

    it works great good, it would be great if the items are well vertically spaced if you notice there are big padding in the bottom also add a delay(transition) for the hovering effect

    Marked as helpful
    1
  • Rashwan-Mohamed•340
    @Rashwan-MohamedPosted about 3 years ago

    the event-listener on the cross button next to each category is set to the middle of the cross"only the icon" if you pressed say on the padding it won't respond

    0
  • Rashwan-Mohamed•340
    @Rashwan-MohamedPosted about 3 years ago

    the text area where the email is written is limited, to some number of words after this the text is spliced.

    0