Mohammed Nasif• 50
@Mohammed-Nasif
Submitted
Ramon Pereira
@RamonAPereira
All comments
- Ramon Pereira• 250
@RamonAPereira
Posted
it would be nice if you change the color of the button so your user knows that it is disabled when no value is selected
0 - louy• 170
@louy999
Submitted
Ramon Pereira• 250@RamonAPereira
Posted
Good Job!
When you submit without select a button, it show the I'm selected "4 of 5", try disabling the button when no value is selected.
0 - Abhishek Bhagat• 40
@abhishekb740
Submitted
Ramon Pereira• 250@RamonAPereira
Posted
Great job!
- Try to disable the button when no value is select because right now is returning "fdhfhhijsbjkdbsjkbkvbx " in this scenario.
- remove the border of the button to look more with the original design.
Marked as helpful
0 - Yago Couto• 220
@YagoCoutto
Submitted
Um pouco de dificuldade em deixar um código mais limpo.
Ramon Pereira• 250@RamonAPereira
Posted
Uma coisa que pode ajudar a manter o código mais limpo na questão do css são os pre processadores, o Sass por exemplo permite que você reutilize código sem precisar reescrever através dos mixins e também torna o css mais legível por conta da indentação. Seu componente ficou ótimo! quase pixel perfeito.
Marked as helpful
0 - Aaron Morse• 200
@Aaron-Morse
Submitted
Ramon Pereira• 250@RamonAPereira
Posted
when you click on the button without selecting a value it automatically becomes 4, you can disable the button when a value is not selected to avoid this issue.
1 - Leslie Fernandez• 290
@leslief10
Submitted
Ramon Pereira• 250@RamonAPereira
Posted
you can disable the button when no option is selected, because in this scenario it is not showing any value on the second page
Marked as helpful
0 - Victor Assis• 20
@ovictorassis
Submitted
Ramon Pereira• 250@RamonAPereira
Posted
-
You can disable the button or show a message when no number is selected. in this scenario when clicking on the button the screen crashes.
-
You can also remove the border of the button to make it look more like the original design
Marked as helpful
1 -
- Ayoub Ahabchane• 290
@ayouchane
Submitted
This is my first time looking at a component and trying to code it 🥳 I appreciate any and all feedback on how I could make my implementations more efficient and resilient. Love you all <3
Ramon Pereira• 250@RamonAPereira
Posted
It's great for desktop! but you should reduce the size of the component, so that it fits on mobile devices without scrolling. this can be done with media query(https://www.w3schools.com/css/css_rwd_mediaqueries.asp).
1
