Skip to content
OverviewSolutions
10
Comments
8
Ramon Pereira
@RamonAPereira

All comments

  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    it would be nice if you change the color of the button so your user knows that it is disabled when no value is selected

    0
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    Good Job!

    When you submit without select a button, it show the I'm selected "4 of 5", try disabling the button when no value is selected.

    0
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    Great job!

    1. Try to disable the button when no value is select because right now is returning "fdhfhhijsbjkdbsjkbkvbx " in this scenario.
    2. remove the border of the button to look more with the original design.
    Marked as helpful
    0
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    Uma coisa que pode ajudar a manter o código mais limpo na questão do css são os pre processadores, o Sass por exemplo permite que você reutilize código sem precisar reescrever através dos mixins e também torna o css mais legível por conta da indentação. Seu componente ficou ótimo! quase pixel perfeito.

    Marked as helpful
    0
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    when you click on the button without selecting a value it automatically becomes 4, you can disable the button when a value is not selected to avoid this issue.

    1
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    you can disable the button when no option is selected, because in this scenario it is not showing any value on the second page

    Marked as helpful
    0
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    1. You can disable the button or show a message when no number is selected. in this scenario when clicking on the button the screen crashes.

    2. You can also remove the border of the button to make it look more like the original design

    Marked as helpful
    1
  • Ramon Pereira•250
    @RamonAPereiraPosted over 2 years ago

    It's great for desktop! but you should reduce the size of the component, so that it fits on mobile devices without scrolling. this can be done with media query(https://www.w3schools.com/css/css_rwd_mediaqueries.asp).

    1