Component using CSS Grid and custom properties
Design comparison
Solution retrospective
This is my first time looking at a component and trying to code it 🥳 I appreciate any and all feedback on how I could make my implementations more efficient and resilient. Love you all <3
Community feedback
- @RamonAPereiraPosted over 2 years ago
It's great for desktop! but you should reduce the size of the component, so that it fits on mobile devices without scrolling. this can be done with media query(https://www.w3schools.com/css/css_rwd_mediaqueries.asp).
1@ayouchanePosted over 2 years ago@RamonAPereira You have no idea how insightful this has been. Thanks a bunch 🙏🏼 I didn't resort to media queries but boy oh boy did I spend hours tinkering with code in the Mozilla inspector. This headache that I'm left with now shall teach me the importance of always starting mobile first.
1 - @Lucas171Posted over 2 years ago
Hey! Great Job on this! From my perspective it looks perfect! The only thing I would recommend adding are the hover and active states, which are shown in the design folder in the downloaded files. Once you do this your site will feel more interactive!
1@ayouchanePosted over 2 years ago@Lucas171 Hey 👋🏼! Thanks for taking the time to look around! I had to keep switching between the images repeatedly to spot the changes. At first, I thought they were referring to the pointer cursors (which change by default so you can imagine my confusion). Thank you so much 🙏🏼 I went ahead and added the hover effects. It should be live now.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord