Kal• 30
@CodeCrafter-kal
Submitted
RajanCP
@RajanCP
All comments
- RajanCP• 50
@RajanCP
Posted
Great job on the solution, looks very similar. Also media queries seemed effective in making it responsive Can't find any issues as of yet
0 - CasperCoder• 20
@CasperCoder
Submitted
RajanCP• 50@RajanCP
Posted
-
Great job, I think your text is slightly different but overall it is very similar to the solution.
-
Try to use rem instead of px for font size as it makes it more responsive.
0 -
- RajanCP• 50
@RajanCP
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of the css styling as I believe it matched up fairly well to the example. However, I spent too much time trying to format the text in html, this should be adjusted later on in css,
What challenges did you encounter, and how did you overcome them?
The tag was overwriting my font weight. I had to replace the tag with , which then allowed me to customise the font weight as needed.
What specific areas of your project would you like help with?
Is the html code semantically correct? Did I create unnecessary when splitting the text up?
RajanCP• 50@RajanCP
Posted
@Stroudy Hi Thank you for this detailed response.
-Regarding the .attribution I do agree it would be considered difficult to read and will consider this going forward.
-I am new to using <meta> will also consider this.
-What is the purpose behind using max-width: 100% or min-width: 100%
-How useful is using a main tag in this instance? Since everything is incapsulated around <body>, I used .body in css to style it. Is this incorrect? Should I be using <main> and styling <main> directly?
-Will use rem units going forward.
0 - shikurassefa• 10
@shikurassefa
Submitted
What are you most proud of, and what would you do differently next time?
the design,and i wana need support on css ,liitle bit.
What challenges did you encounter, and how did you overcome them?
i did not face any challenges
What specific areas of your project would you like help with?
css
RajanCP• 50@RajanCP
Posted
Need to spent some time reading on 'display flex' and how to make sure your main block is appropriately aligned in the centre.
0 - emeraldknytt• 90
@emeraldknytt
Submitted
RajanCP• 50@RajanCP
Posted
Correct usage of body and divs tag Add a README to provide additional live site url Code is well-structured It is very similar to the design, only differing in position
Marked as helpful
0
