@Stroudy
Posted
Hey Great solution, You should be proud, Somethings to consider,
- Your
.attribution
has a low-contrast text and is difficult or impossible for many users to read. Link text that is discernible improves the experience for users with low vision. You can change this by using a Contrast Checker, - Missing a
<meta>
description tag for SEO purposes, I do not want to give you the answer but just to point you in the right direction. - It is best practice to have a
<main>
tag inside your body highlighting the main section. - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻