Skip to content
OverviewSolutions
8
Comments
8

Prince Awuah Karikari

@PRINCEKK122London UK170 points

A life long learner, with a strong desire to solving problems efficiently.

Latest solutions

View more solutions

Latest comments

  • P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted 3 months ago

    Solution looks good, but the a couple of pointers that I believe it will make the site look like that of the mockup.

    1. The font used does not match the one on the design. Your css import looks good, but you have to take a look into that again.

    2. The container too also lacks the box shadow.

    0
  • P
    Lovro Peraić•330
    @loki-pepeSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    Even though the project was so small and simple, I am proud of using semantic HTML elements, abandoning my previous habit of using generic div elements coupled with a myriad of classes.

    What challenges did you encounter, and how did you overcome them?
    • Image gap: At first the gap between the QR code image and the element below it baffled me, but setting the display property of the image to block solved the issue.
    • Horizontal and vertical centering: I was unsure what the best approach to this problem would be. I knew the desired alignment could be implemented with grid or flexbox, but considering the simple structure of the page I deemed neither of the two layout mechanisms were necessary and I opted for the following solution:
    body {
    position: relative;
}

main {
    position: absolute;
    top: 50%;
    left: 50%;
    transform: translate(-50%, -50%);
}
    What specific areas of your project would you like help with?

    • Sizing different to design: While the height of the heading content box in the design file was 52px, the height of the same content box in my generated page was 52.81px (using the same font, font size, line height and letter spacing as specified in the design file), which slightly shifted the content below the image. I thought it to be reasonable enough to ignore this difference, but I would like to know if this should be fixed and how.

    • Fixed height and width of main content: as the design file didn't call for dynamic sizing, I set the dimensions of the main element using height: 499px; and width: 320px;, as specified in the design file. Was this the right approach?

    Static QR Code Component

    1
    P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted 3 months ago

    Great solution, and the projects looks great on all screen sizes.

    0
  • P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted over 1 year ago

    Congrats on knocking this project off.

    I think you can enhance the site and take it to the next level, I saw that upon hovering the cursor on the learn more button in the hero section, the height the hero section increases a little bit, and when the mouse leaves that element, the height decreases.

    Also, I would suggest that you give the main section a max-width, as viewing the content in the main section becomes too long when viewed on a large viewport.

    I hope this helps, and once again, job well done.

    Marked as helpful
    1
  • P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted over 1 year ago

    Congratulations on completing this project, however, I am unable to follow the links above to the live site, and I also tried following the link in your github repo, but both are showing error messages.

    Please rectify this problem, so we will be able to see the great work you have done.

    Cheers

    Marked as helpful
    0
  • P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted over 1 year ago

    Great work, what's next on your radar?

    0
  • P
    Prince Awuah Karikari•170
    @PRINCEKK122Posted over 1 year ago

    Congratulations on knocking this task off.

    I took a look at your site, and I saw the UI breaks, where the founder section goes under the services container on the tablet devices. I think you should take a closer look at this especially around the position: relative of this side of your code, more specifically with the z-index side. Also do well to look into min-height and max-height properties of the services container.

    .founderSect {
display: flex;

justify-content: center;
position: relative;
height: 40vh;
max-height: 400px;
}

.image-founder {
max-width: 281px;
position: absolute;
bottom: -55px;

z-index: 1;

margin-top: 50px;
}

    And it seems we have completed the same projects together, which project are you taking up next? I am looking into doing more of the premium challenges, as I have realized that those a little bit challenging than the free ones.

    I hope I was of help with this review. Happy coding!

    Marked as helpful
    1
View more comments