All comments

• 

  GiwaHalim• 140

  @GiwaHalim

  Submitted over 1 year ago

  it was a good project to test my html and css after writing javascript all these while.

  

  frontend mentor qr code challenge using just html and css

  2

  60

  

  Cephas• 540

  @Olowo290

  Posted over 1 year ago

  Hi, congrats on the completion of this project. It looks good on different screen sizes. However, you can make your html more semantic by replacing your div tags with semantic tags such as "main", "section", and "article" tags. Above all you did pretty well completing the project.

  Don't forget to mark as helpful if you find it so.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Emmanuel Akpan• 790

  @heisemmaco-dev

  Submitted over 1 year ago

  This my second responsive layouts built please rate my lay out

  

  QR CODE USING CSS, Building Responsive Layouts with html and css

  1

  60

  

  Cephas• 540

  @Olowo290

  Posted over 1 year ago

  Hi, congrats on completion of this project. some of the flaws I would like to point out so you can improve on them are:

  • The use of div tag in your HTML can be replaced using more semantic tags like "section", article. -Looking at it, the card is not responsive on smaller screen because of the hard coded width of 744px in your stylesheet. what I'll suggest is either you reduce the width of the card to the one that will be responsive in all screens or use media query to give it different width at different screen sizes. Above all, I commend your effort in completing the project. Don't forget to mark this as helpful if you find it so.

  Marked as helpful

  0