frontend mentor qr code challenge using just html and css

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • You don't need to specify a class <footer class="footer"> in the <footer> tag, just the <footer> tag is enough. Also, it's equivalent to the <div class="attribution"> in the <footer> tag, so you can just use the <footer> tag instead of the <div class="attribution">.
  • Additionally, you need to replace <div class="container"> with the <main> tag to fix the accessibility issues.
  • You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  GiwaHalim•140

  @GiwaHalimPosted over 1 year ago

  @ecemgo thank you very much, i'll improve on these

  0
• 

  Cephas•540

  @Olowo290Posted over 1 year ago

  Hi, congrats on the completion of this project. It looks good on different screen sizes. However, you can make your html more semantic by replacing your div tags with semantic tags such as "main", "section", and "article" tags. Above all you did pretty well completing the project.

  Don't forget to mark as helpful if you find it so.

  Marked as helpful

  0

  ---

  

  GiwaHalim•140

  @GiwaHalimPosted over 1 year ago

  @Olowo290 thank you very much, ill improve on these

  0