@ecemgo
Posted
Some recommendations regarding your code that could be of interest to you.
- You don't need to specify a class
<footer class="footer">
in the<footer>
tag, just the<footer>
tag is enough. Also, it's equivalent to the<div class="attribution">
in the<footer>
tag, so you can just use the<footer>
tag instead of the<div class="attribution">
. - Additionally, you need to replace
<div class="container">
with the<main>
tag to fix the accessibility issues. - You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.
Hope I am helpful. :)
Marked as helpful
@GiwaHalim
Posted
@ecemgo thank you very much, i'll improve on these