Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

frontend mentor qr code challenge using just html and css

GiwaHalim 140

@GiwaHalim

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


it was a good project to test my html and css after writing javascript all these while.

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • You don't need to specify a class <footer class="footer"> in the <footer> tag, just the <footer> tag is enough. Also, it's equivalent to the <div class="attribution"> in the <footer> tag, so you can just use the <footer> tag instead of the <div class="attribution">.
  • Additionally, you need to replace <div class="container"> with the <main> tag to fix the accessibility issues.
  • You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

Hope I am helpful. :)

Marked as helpful

0

GiwaHalim 140

@GiwaHalim

Posted

@ecemgo thank you very much, i'll improve on these

0
Cephas 540

@Olowo290

Posted

Hi, congrats on the completion of this project. It looks good on different screen sizes. However, you can make your html more semantic by replacing your div tags with semantic tags such as "main", "section", and "article" tags. Above all you did pretty well completing the project.

Don't forget to mark as helpful if you find it so.

Marked as helpful

0

GiwaHalim 140

@GiwaHalim

Posted

@Olowo290 thank you very much, ill improve on these

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord