@Nipaaaa1
@b-kuhu
Submitted
Although i am aware of using media queries for sizing accordion according to different sizes but somehow i feel this is not the most efficient way to do it. Will appreciate any feedback on how to improve from here in CSS of my project,
@Nipaaaa1
Posted
Congratulations on completing this challenge!
There's something you could do to improve the CSS here.
You're using height: 60% for the container. While sometimes it's a good thing to do, in this case, using height: auto will make the container height resize according to the content.
You will notice the container just collapses if the screen height is smaller.
Anything else is fine, Good Job!
@Nipaaaa1
Submitted
Hello! This is my solution for this Challenge!
This is actually a simple challenge. But it makes me realize I didn't know the basics of API that much. On the good side, now I could properly animate something with framer motion. Though I still struggle with layout animation.
If you had a good resources to learn about API (Like YouTube playlist, article, web, or anything!). Kindly share with me and other people who saw this challenge, you're helping a lot of people by doing that.
But still Any Feedback is Appreciated so if you could look at the code and give a feedback, it really helps. Also, if you haven't review other people code or give a feedback before, feel free to use this as a practice.
Anyway, Happy Coding!
@Nipaaaa1
Posted
The screenshot looks like that because of the animation. Sorry, I couldn't do anything about it :(
@JulioCode13
Submitted
Please provide feedback Constructive criticism would help me improve.
@Nipaaaa1
Posted
Congratulations on completing your first Challenge!
I see your code and there's a bit things you could do to make it even better:
First, your using CSS Variables for paragraph and if you write it like this:
--paragraph: 'Figtree';
and implement the font like this:
.date {
font-family: sans-serif; /* This is the fallback font for older browser */
font-family: var(--paragraph);
}
The fonts problem will go away. The reason you should use separate font family for fallback font is because it'll break at older browser if you're using CSS Variables, since it didn`t support for older browser.
Everything else is fine, Good Job!
Marked as helpful