Blog preview card

Community feedback

• 

  Nipaaaa1•350

  @Nipaaaa1Posted 11 months ago

  Congratulations on completing your first Challenge!

  I see your code and there's a bit things you could do to make it even better:

  First, your using CSS Variables for paragraph and if you write it like this:

  --paragraph: 'Figtree';
  

  and implement the font like this:

  .date {
    font-family: sans-serif; /* This is the fallback font for older browser */
    font-family: var(--paragraph);
  }
  

  The fonts problem will go away. The reason you should use separate font family for fallback font is because it'll break at older browser if you're using CSS Variables, since it didn`t support for older browser.

  Everything else is fine, Good Job!

  Marked as helpful

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello Julio!

  Your solution looks excellent!

  I have just one suggestion:

  • Use only main to wrap the main content instead of main and section. Unless you have a specific reason do use them both, it's not necessary. The tag section would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Ranit Manik•880

  @RanitManikPosted 11 months ago

  • In the card design challenge, it was stated that the shadow of the card should grow on hover, but in your case, that is missing.
  • The fonts you used are not from the same family as the design.

  0