Niklaus
@NiklausRupailAll comments
- @woycziSubmitted almost 2 years ago
- @rick881Submitted about 2 years ago
any feedback is greatly apprerciated
@NiklausRupailPosted about 2 years agoAlmost done, well done. You can change background-color for the one provided in style-guide.md and add a little bit more padding on buttons.
0 - @Bahbah89Submitted about 2 years ago
Fun challenge to experiment with flexbox more and making the website responsive on mobile phone. 2 main struggles I had with this one:
- when the screen got smaller horizontaly the buttons got pushed further down outside the frame of their own section.
- the footer pushed the container class to the left of the screen causing it not to be centered anymore,(luckily by using flex-direction column in "body" this solved the issue).
When researching regarding the "button" type, apparently flexbox can´t be used on it. Any advice how to tackle this one is welcoming. i saw you could also use grid for this. My default answer was using position absolute :).
Any other advice or tips are most appreciated!
@NiklausRupailPosted about 2 years agoCongrats on finishing the challenge! To fix button problem you should set the max-width property on paragraphs so they don't scale that much when changing viewport. Also you can delete that footer because it's not in the design and set background-color to the color in style-guide.md!
1 - @jonexistSubmitted about 2 years ago
This project was amazing actually but I struggle in designing this <hr> can anyone please suggest best practices for making horizontal line without using <hr> element? I'd appreciate answer/tips from this community!
@NiklausRupailPosted about 2 years agoOne way and the way I did it is to create a div with height of 1px
.line { height: 1px background: white; width: <desired width>; }
Marked as helpful0 - @ImpodaysSubmitted about 2 years ago
My solution to QR-code-component challenge. Please give a review
@NiklausRupailPosted about 2 years agocreate a div with class container or use body tag, but you need to center that div body { height: 100vh; } and then .card { display: flex; justify-content: center; align-items: center; }
Marked as helpful1