Skip to content
OverviewSolutions
13
Comments
3
Murillo Pinheiro de Oliveira
@MuriWolf

All comments

  • Murillo Pinheiro de Oliveira•250
    @MuriWolfPosted over 2 years ago

    Hi bro! whats up?

    Congrats for finishing this challenge!

    I just wanna give you some advices, then you can fix it. First, you layout looks great! But the math part is not doing well, for me just worked after i press the reset button, but the math is not 100% correct. In the tip amount, you could use: (bill * percentage / 100) / people, and for the total: (bill * percentage / 100) + bill) / people. (The percentage is the 5%, 10%, 15%... and you could execute the math when the user clicks in the percentage, then the program gets the two inputs, do math and show the results.)

    If you have some question or anything, please do! I will try to help you.

    1
  • Chisom Ogbonna•380
    @MavreonSubmitted over 2 years ago

    I just started learning the react framework about a week ago and decided to take on a challenge here that I could use to test my understanding so far. I had a fun time making this, any feedback is well appreciated!😗

    Time Tracking Dashboard

    2
    Murillo Pinheiro de Oliveira•250
    @MuriWolfPosted over 2 years ago

    Whats up, dude?

    I just wanna to give a advice, when the screen width size is around 1099px, the layout breaks, so try to uptade your code by using some media query and/or display grid to make it more responsive. (Just dont use a lot of media queries if you will use it)

    Btw, congrets on completing the challenge! Sometime i should learn React :P.

    Marked as helpful
    0
  • Dan•220
    @DanRHatfieldSubmitted over 2 years ago

    I didn't realize that JSON was provided so I wrote my own Javascript. For the life of me I couldn't find a solution to optimize the mouse events though I'm certain there is one and if found it'd make the code much nicer.

    Also, I wasn't able to get the ellipsis to have a hover over effect as they were inside the box that was already an element that had triggered for a mouse event. How would I do that in the future?

    Please provide feedback and suggestions. I'm still learning.

    Thanks!

    Time Tracking Dashboard - Used Visual Studio Code

    1
    Murillo Pinheiro de Oliveira•250
    @MuriWolfPosted over 2 years ago

    Hi dude, whats up?

    Firts of all, congrets on completing the challenge! I want to give a suggestion, to this challenge the "display grid" is really important, and i see you didnt used it, so maybe you should learn it to improve your knowlogde, and then try to uptade this challenge using the grid. Have a nice day!

    0