Only a desktop version
Muazzam
@MuazzyAll comments
- @rondelekSubmitted over 2 years ago@MuazzyPosted over 2 years ago
Nice work Ewellna, Just a few suggestions:
- if you want to make your design pixel perfect (as close to the design), then set max-width: 1440px of the main container, and then code accordingly
.container { max-width: 1440px; }
- Avoid using <section> unnecessarily, only use it when you have some heading <h1......h6> inside it, otherwise it will give these weird issues of Html validation. Use <div> instead
Marked as helpful1 - @satzzzzz07Submitted over 2 years ago
Hey Guys, Open to feedback and suggestions.
I was wondering why I was not able to add a
border-radius
at the bottom. I tried some solutions. Not working. Kindly advise on that. Thanks@MuazzyPosted over 2 years agoNice job sathya, it looks like the "main" div's property "border-collapse:" was set to "collapse" which was preventing the border-radius to show. just modify these lines and you will be good to go.
main { border-collapse: separate; border-radius: 1rem; overflow: hidden; //hide the image corners which are overflowing }
main img { border-radius: 7px 7px 0 0; //remove this line }
Marked as helpful0 - @ugochukwuuuSubmitted over 2 years ago
Any and add suggestions/ advises are welcomed. Thank You.
@MuazzyPosted over 2 years agoTry to increase button font size and give some spacing (padding or margin) bw different sectoins.
1 - @m67uzairSubmitted over 2 years ago
I found it really hard to fit the content in the div but then I learned about flexbox so its all good. I couldn't get it to be completely or seamlessly responsive because I still lack in that department. UPDATE: made it somewhat responsive under the 375px area.
@MuazzyPosted over 2 years agovery impressive even tho it was your first time using flexbox
1