Skip to content
OverviewSolutions
22
Comments
5
Mulugeta
@MrDevM

All comments

  • Mulugeta•360
    @MrDevMPosted 11 months ago

    your attempt is not bad Here's some feedback first u use 90% of your code contain flex box don't use it that much means u should use it for layout the second thing is practice text styling more like font's line padding margin box model width/height etc... from source i prefer you w3schools it's the best for learning the another is don't set height and width for an html element it make your website not responsive in

    general learn more

    0
  • Mulugeta•360
    @MrDevMPosted 11 months ago

    Your project looks very good!

    If you give the container a

    .card:has( .card-information-title:hover ){
box-shadow: 12px 12px 0px 0px #000;
}

    it'll look even closer to the original design.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    0
  • Mulugeta•360
    @MrDevMPosted 11 months ago

    feedback on dom use bubbling instead of for each

    Marked as helpful
    0
  • Mulugeta•360
    @MrDevMPosted 12 months ago

    Great job on your solution. I looks fantastic.first I noticed that the h1 font is too small give font size to h1's around 40px

    h1{
  font-size:40px; /* or 2.5 rem*/
}

    secondly is give lien-height for paragraphs it look like close one to other so give a line-height to paragraphs

    p{
 Lien-heigh :25px; /* or 1.5 rem*/
}

    Finally button part it looks 100% width instead give padding around 15px top bottom and 35px left right padding and a font-weight

    button{
  padding:15px 35px;
  font-weight:bold;
}

    Thanks.

    Marked as helpful
    8
  • Ghanim Ali•90
    @TakindaSubmitted 12 months ago

    i think i have a problem with where thing are aligned i need to know a way so i can check how the page will look like in other screens other than 1080p or phones cause i think the page will look wrong on other screens

    3-column-preview-card-component-main-tawny-rho

    1
    Mulugeta•360
    @MrDevMPosted 12 months ago

    Great job i see some problems there the first one is the main section height don't set an height instead set width

    main{
  width:920px ;/* or use  rem around 55 rem*/
}

    cancel height of main element because of that overflows happens after Set width instead this all tings will be fine

    the second problem is lien-height of paragraph p decrease it to around 25px

    Otherwise Great Job Thanks

    Marked as helpful
    1