Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • JaceLee• 240

    @jaceleedev

    Submitted

    What are you most proud of, and what would you do differently next time?

    1. Having learned a lot from my previous project, the newsletter form, this time I took the opportunity to consolidate what I had learned. As I was finishing the project, I discovered that fonts need to be applied separately in Storybook. I learned that if the fonts are different, it can cause confusion as the appearance in Storybook might differ from the actual project.

    2. I tried using useSWR. Instead of importing the data.json provided by the challenge as a static file, I used the API functionality provided by Next.js to fetch it. This allowed me to retrieve data easily and conveniently without using useEffect. Also, I found its simple usage to be very efficient in progressing with the project. A similar library is tanstack-query, which seems to have more features than useSWR and could be useful for managing complex server states.

    What challenges did you encounter, and how did you overcome them?

    The Figma design system for this project was somewhat unfriendly from a developer's perspective. There were inconsistencies in line heights, meaningless 1-2px measurements, and odd pixel values. The oversized profile image also made precise clicking difficult. While ideally, design systems would be perfectly organized for developers, including component names and color designations aligned with industry standards like Tailwind CSS, this isn't always the case in real-world projects. Despite these frustrations, I overcame these challenges by completing the project, recognizing that as a professional, I need to deliver results even in less-than-ideal circumstances. In a work environment, communication would be key to addressing these issues.

    What specific areas of your project would you like help with?

    Any tips related to this project are welcome.

  • P
    trskldnt• 80

    @trskldnt

    Submitted

    What challenges did you encounter, and how did you overcome them?

    list-style-position: outside;

    What specific areas of your project would you like help with?

    If you have time, please provide feedback.

  • @Mohammed-Nedjima

    Posted

    Great work! One simple note, it's important to use rem and em instead of precise pixels since it's more convenient and an accessibility standard. Specially in font-size

    Marked as helpful

    0
  • @Mohammed-Nedjima

    Posted

    Hello there! Congrats 🎉 for completing this challenge and I wish you an exciting journey as a frontend developer. Your work looks great overall but there is some advice you can use to improve yourself:

    • It's better to put the title tag at the top of the head element for performance reasons, it should be the first thing to be rendered.
    • Try to use descriptive class names. Instead of pic, pic1, container-sub, yellow, and small, use image, illustration, card-content, card-tag, card-release, and so on. It won't make a difference in small tasks like this, but you should practice for bigger projects when you work with other developers. It's also good for yourself since it makes the code more readable. -NEVER USER PIXELX FOR FONT SIZES, this is a common mistake at the beginning of your path. The reason for this is that rem values are changeable according to the user's browser settings. unlike pixels which are fixed-size. -It's better to edit the readme file with some details about the challenge how did you go through the challenge and what difficulties you encountered. You are not obliged to keep the links of frontendmentor on the button of your HTML file.

    Marked as helpful

    0
  • P
    Peter• 60

    @peter-hasznos

    Submitted

    What are you most proud of, and what would you do differently next time?

    I solved this challenge very fast.

    What challenges did you encounter, and how did you overcome them?

    I am not confident yet to decide which semantic elements use and when.

    What specific areas of your project would you like help with?

    I gladly accept every feedback where I can improve my code. Thanks for your help in advance.

    @Mohammed-Nedjima

    Posted

    • It's better to use css costom properties instead of placing the values directly in the classes
    • Try use rem and em more often instead of px
    • Instead of resetting the body and img properties at the top of your css, use a prewritten css styles from the Internet
    0