@krebeDevSubmitted almost 5 years ago
My first advanced project. Learnt a lot working on this. Feedback is highly appreciated.
Mohamed ELIDRISSI
@MohamedElidrissiAll comments
- @MohamedElidrissiPosted almost 5 years ago
Nice work, if you want more challenge, you can seperate the functionality into seperate files and use ES Modules with a module bundler such as Webpack or Parcel, or even a framework like React. Good luck!
1 - @HawKyreSubmitted almost 5 years ago
I could not figure out how to put the dot next to "pricing" so I put a dash line instead. Any idea?
@MohamedElidrissiPosted almost 5 years agoI'd guess you already know it doesn't display well in mobile currently?
0 - @kuroyzaSubmitted almost 5 years ago
I would love to know some suggestion to enhance my design, Thank You so much!
@MohamedElidrissiPosted almost 5 years agoGreat job Hamza, happy to see more Morrocans here ;) Did you know you can do most of the form validation using CSS only? You can use the :invalid pseudo class in conjunction with the
requiredattribute to trigger stylings only when an input is invalid2 - @alfonsosuarezgSubmitted almost 5 years ago
Is my code readable? That is, I want to know if my HTML code is intuitive and my CSS style sheet well-documented.
@MohamedElidrissiPosted almost 5 years agoI'm in no way an expert, but if I'm using floats I'd make sure it displays properly on IE, here's how it looks on IE11: https://imgur.com/a/Dnc3Xgq
2 - @joeybergeronSubmitted almost 5 years ago@MohamedElidrissiPosted almost 5 years ago
Did you notice at a certain width like 1185px it breaks?
0 - @AlbertoIJSSubmitted about 5 years ago
- I couldn't get the "we're" with the right font-weight.
- I did the mobile version with chrome dev tools and it seems to work right but when i re-size the window manually it doesn't work for me.
Any suggestions are appreciated.
@MohamedElidrissiPosted about 5 years agoI notice that you made the heading text uppercase in your HTML, that will make screen readers spell it word by word(as if its an abbreviation), you should apply a
text-transform: uppercasein CSS instead.1
