Four card feature section (using only floats properties for layout)

Community feedback

• 

  Mohamed ELIDRISSI•150

  @MohamedElidrissiPosted almost 5 years ago

  I'm in no way an expert, but if I'm using floats I'd make sure it displays properly on IE, here's how it looks on IE11: https://imgur.com/a/Dnc3Xgq

  2

  ---

  

  Alfonso Suarez G.•55

  @alfonsosuarezgPosted almost 5 years ago

  @MohamedElidrissi Ohhh, I didn't knew it. Sorry, I can't test with IE because I'm working on Linux.

  Thanks for notify the issue! I will need to research why that happen...

  0

  

  Mohamed ELIDRISSI•150

  @MohamedElidrissiPosted almost 5 years ago

  @alfonsosuarezg a Windows VM should do you fine

  0

  

  Alfonso Suarez G.•55

  @alfonsosuarezgPosted almost 5 years ago

  @MohamedElidrissi Yeah. Although I don't if my little notebook might run it.

  Thanks a lot for your help!!!

  0
• 

  P

  Joshua Briley•415

  @somecallmejoshPosted almost 5 years ago

  Nice job on this project. I agree with Mohamed's comments about using floats. There are more effective ways to lay this out, primarily CSS Grid. Flexbox is another option. You can avoid the clearfix hack by using grid. And, it's much easier to maintain once you learn the syntax.

  The HTML looks good to me. The W3C validator isn't returning any errors. My only recommendation would be to have a closer look at the <h1> tag.

  <h1>
        Reliable, efficient delivery<br>
        <strong>Powered by Technology</strong>
      </h1>
  

  I think you can make a good case for coding this like you did. When I read the two lines out loud, it makes sense that they go together and could be combined into a single <h1> element like you have them.

  When I look at the design, I wonder if the intent is for them to be separate thoughts. Based on the differences in capitalization, it could be argued that the phrase Reliable, efficient, delivery is one thought, and Powered by Technology is a different one—each standalone pieces of content.

  Your code is probably correct. But, this is something I would definitely ask the designer to clarify. Again, nice work on this project.

  1

  ---

  

  Alfonso Suarez G.•55

  @alfonsosuarezgPosted almost 5 years ago

  @somecallmejosh Thanks for your words!!! I appreciate that.

  Yes, in fact, I love CSS Grids and Flexbox. I went to try make it retro-compatible, but I notice that doesn't work on IE.

  Also, I thought to convert Reliable, efficient, delivery to a paragraph, but was a little confused.

  However, I had split <h1> tag to increase readability for myself. Due to I'm working with 80 columns width for the text editor. From now, I will avoid it.

  Thanks a lot!!!

  1