Skip to content
OverviewSolutions
6
Comments
5
Mehemmed77
@Mehemmed77

All comments

  • kmnkat•30
    @kmnkatSubmitted over 2 years ago
    1. Is that responsive enough?
    2. Code refactoring - what can I do better?
    3. Are my JS function well written? Can I do something better?
    4. I decided to add classes (with new CSS style) of components for page transition and change the appearance of clicked button. Is that a good solution? Are there any other options (except of adding inline HTML style)?

    Interactive rating element

    1
    Mehemmed77•100
    @Mehemmed77Posted over 2 years ago
    1. and also 2) It is responsive but not in devices that have 420px width or lower.your #rating-section div overflows Solution:Try to add max-width or give it width with percentage and don't give fixed width or heights just don't do it.Give it max-width or width with percentage.I hope this is useful; https://www.youtube.com/watch?v=VQraviuwbzU&t=694s watch this video at 4:47 He talks about it.

    I liked your JS logic it is really good.You approached it differently than me and i liked it!

    Marked as helpful
    0
  • Saurav sanjel•60
    @master8848Submitted over 2 years ago

    how coud have i done js part better, i can write css js logic was crazy

    not responsive

    1
    Mehemmed77•100
    @Mehemmed77Posted over 2 years ago

    don't place block elements inside inline elements it can cause issues and it is not easier to control it unless you give inline element property of display:block;but overall it is good!

    0
  • Kingsley Agu•285
    @didyouseekyngSubmitted over 2 years ago

    I'm super excited because this is my first JavaScript challenge. I've been working on it for days alongside some others, which I'll submit soon. Feel free to check it out. I used CSS Animation to make things smooth between the rating and thank you state, overall operations were smooth. Try moving around the page with the Tab key and tell me what you think. @grace-snow I know how you like working around a page with keyboard only. Please check out this component where I tried implementing some accessibility features and let me know areas I need to improve on. Thanks!

    Smooth Interactive Rating Component with CSS Animation

    2
    Mehemmed77•100
    @Mehemmed77Posted over 2 years ago

    Love the transitions!

    1
  • Lozie•70
    @LozPilafasSubmitted over 2 years ago

    Hey!

    Any advice or recommendations would be greatly appreciated.

    Really enjoyed putting this little component together. Tools and techniques used: #HTML & CSS #React #Data source enabled - the component's chart is dynamic is solely driven by the json data provided, theoretically you could make it fetch from any api and work! #NOTE: highlighted date is also data driven so it will vary from the design based on the date! (so if today is Saturday, it will highlight Saturday) #built with React #No chartJS

    Pull requests welcome!

    thanks Loz

    Implemented using HTML and CSS with flexbox - React + data src (json)

    1
    Mehemmed77•100
    @Mehemmed77Posted over 2 years ago

    I love that date feature so good!

    1
  • Mehemmed77•100
    @Mehemmed77Posted over 2 years ago

    I think you mean that little brown tag bar.I also completed this challenge with Vanilla JS. Simply add events. 1.onmouseover show that tag bar; 2.onmouseleave hide that tag bar; By default you can make those tag bars "display:none;" this will make it completely disappear. and when hovering make them "display:block"

    Marked as helpful
    1