Design comparison
SolutionDesign
Solution retrospective
- Is that responsive enough?
- Code refactoring - what can I do better?
- Are my JS function well written? Can I do something better?
- I decided to add classes (with new CSS style) of components for page transition and change the appearance of clicked button. Is that a good solution? Are there any other options (except of adding inline HTML style)?
Community feedback
- @Mehemmed77Posted over 2 years ago
- and also 2) It is responsive but not in devices that have 420px width or lower.your #rating-section div overflows Solution:Try to add max-width or give it width with percentage and don't give fixed width or heights just don't do it.Give it max-width or width with percentage.I hope this is useful; https://www.youtube.com/watch?v=VQraviuwbzU&t=694s watch this video at 4:47 He talks about it.
I liked your JS logic it is really good.You approached it differently than me and i liked it!
Marked as helpful0@kmnkatPosted over 2 years ago@Mehemmed77 Thanks for your comment :) I am going to fix it. I like the video you sent - I think that responsiveness is still hard for me but I hope this advice will help :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord