Skip to content
OverviewSolutions
21
Comments
30
Mayur Mali
@Mayurtm29

All comments

  • Mayur Mali•810
    @Mayurtm29Posted over 2 years ago

    Hey, Samarth good work. just warp your all code in the main tag to solve the accessibility issues & on mobile view center your loading animation. if the user has no internet connection then show an error message like failed to fetch or check your internet connection. happy coding ☕

    Marked as helpful
    0
  • Mayur Mali•810
    @Mayurtm29Posted over 2 years ago

    add an alt attribute to images and border radius. wrap all code in the main tag and add hover effects to buttons and use display flex to center the content

    1
  • Mayur Mali•810
    @Mayurtm29Posted over 2 years ago

    good work happy coding

    Marked as helpful
    1
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    give alt attribute to images and id has to be unique so instead of id use class to target multiple elements at once and background quotation.svg is overflowing correct that.

    happy coding

    0
  • dayakness•50
    @badgateway505Submitted almost 3 years ago

    Hello! I would be glad to hear any feedback on this. Probably not very semantic and poor box-shadow, but anyway it'd cool if you say some points to get better with layout and css basics.

    Fixed qr-code solution with flexbox

    2
    Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    generate new screenshot and next time make sure you upload the solution after the website live on github pages.

    0
  • IRVINE MESA•1,855
    @DrMESAZIMSubmitted almost 3 years ago

    I have completed this challenge as well did YouTube video for the challenge .Please give me feedback for everything

    YouTube video link : https://www.youtube.com/watch?v=kMxaHrc90pg

    Thank you all in advance for the feedback.

    Order summary component challenge and Youtube Video

    2
    Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    it is too wide decrease the the width.

    0
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    your website is not live on github pages check that and wrap your all content in main tag

    Marked as helpful
    0
  • Caio de Alcantara Santos•250
    @caio-alcantaraSubmitted almost 3 years ago

    This was the first project I did using the "mobile-first" approach, and I actually think it helped a lot for responsivity. However I had a problem when trying to do the active state (hover) on the links. Basically, I set the link's colors to the same color as the background. I thought the right way of doing it would to set the text color to 'transparent' but that didn't work out. Anyway, the solution I found worked out great until I had to do the hover state. I couldn't manage to get the link's background-color to be transparent, and the text color to be white (not managing to change the text color to white is the big issue here, I think). Can anyone help me with that?

    Responsive 3 Column Preview Card using Flexbox/SCSS and Mobile-First

    5
    Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    Hi Caio , First learn more button is not aligned properly

    0
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    Add alt attribute to images to avoid issues.
    happy coding 😊

    Marked as helpful
    1
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    Heading levels should only increase by one for e.g h1>h2>h3 like this

    Marked as helpful
    0
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    add alt attribute to images to avoid ACCESSIBILITY issues

    Marked as helpful
    0
  • Mayur Mali•810
    @Mayurtm29Posted almost 3 years ago

    swap the positions of karma and calculator

    Marked as helpful
    0