Using basic HTML with external & inline CSS

Community feedback

• 

  Mayur Mali•810

  @Mayurtm29Posted almost 3 years ago

  your website is not live on github pages check that and wrap your all content in main tag

  Marked as helpful

  0
• 

  Deepak Parmar•490

  @deepak-parmarPosted almost 3 years ago

  @nathangalung, your solution is not live yet. github-pages deployment process is failed for some reason, it's also an issue for your NFT card solution as well.

  • you might wanna rename your .html file to index.html this way main webpage will directly show up without mentioning their file names.
  • although your code is alright, good work on that part 👌, you should use the semantic <main> tag and <h1> instead of <h2> for main text header to dodge a few accessibility warnings.

  Marked as helpful

  0

  ---

  

  Bryan Hutagalung•30

  @nathangalungPosted almost 3 years ago

  @deepak-parmar i have upload on my repository in github but still cant show the live website. Should i change my file name from QR Code Component.html to QR Code Component index.html? Or i have to find another hosting website? Btw, thx for you comment sir

  0

  

  Deepak Parmar•490

  @deepak-parmarPosted almost 3 years ago

  @nathangalung I cannot figure out the error in your GitHub Pages deployment. When I tried by forking your repo, it worked and the site came live.

  File name doesn't matter here because deployment build process is failing (but it's worth a try, change it to just index.html). If this issue still not resolved I suggest creating new repo and resubmit the challenge. 😐

  0

  

  Bryan Hutagalung•30

  @nathangalungPosted over 2 years ago

  @deepak-parmar thanks sir its done

  0