@ismailhasirSubmitted 17 days ago
P
Matthew
@MattJM1007All comments
- @MattJM1007Posted 17 days ago
Great job! I like that your javascript looks very simple and straightforward. It looks like the min height on your main container is making the desktop site too big. I think if you remove that you could let the content dictate the size instead of setting that height.
Marked as helpful0 - @Richard1876Submitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
i didn't put the social links in a link tag ill do that next time
What challenges did you encounter, and how did you overcome them?to add the point down edge in the social like section was new to me but i improvise
What specific areas of your project would you like help with?Feedback is welcome.
@MattJM1007Posted 28 days agoHi Richard! Overall it looks good. The layout is good and noticed you added the social buttons! Great job. Only thing I would improve is maybe brightening up the colors to match closer to the design. Could also be worth considering semantic html for accessibility if that's something you want to learn.
0 - @J4NBISubmitted 7 months ago@MattJM1007Posted 7 months ago
Great job! I would just thinking about decreasing the size of some of the headings to match the design. Otherwise looks great!
0 - @b4khtiarSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
_
What challenges did you encounter, and how did you overcome them?_
What specific areas of your project would you like help with?_
@MattJM1007Posted 7 months agoReally great job here. Everything looks well done and impressive!
0 - @Anuar06Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
0
What challenges did you encounter, and how did you overcome them?0
What specific areas of your project would you like help with?0
@MattJM1007Posted 8 months agoThe layout looks great and it likes you did that with just flexbox. I didn't know that was possible! Great job!
Only thing that seems to missing is some of the text isn't styled quite right. I think that would really elevate the design. But overall, great work!
Marked as helpful0 - @raficode2303Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
- learnd about
,tags. - how to use
srcsetattribute images for different devices - to use
@mediain `` tag - it took me more hours than what i was expected
it was a challenge to ensure correlation between the @media break to change image, and the grid break from 1 column to 2 columns. to overcome it i used the browser DevTools to check the result and tune it in the browser
What specific areas of your project would you like help with?none
@MattJM1007Posted 8 months agoHi Rafi. Overall this looks great! amazing job and layout looks good. One thing I noticed in your html code is that you used an h1 then an h4. I believe it is not good to skip values like this. It would better to use an h2 instead of an h4, since it won't affect the font size, but it is better for accessibility.
Marked as helpful1 - learnd about
- @Mys1337Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
The project didn't take a long time to finish and I'm becoming more faster since my first project.
What challenges did you encounter, and how did you overcome them?Nothing was really challenging. Just had to do some review for the html table
What specific areas of your project would you like help with?I don't have any specific questions of feedback. But I would like to have your opinion about my code (quality, reusability, readability,...)
@MattJM1007Posted 8 months agoHi Miarinaly!
Great job completing this project! I like the way the table format came out in your solution. I struggled with that a bit on mine. As for as feedback on your code, I am a beginner myself but from what I can tell it looks good!
0 - @nvallineSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I am happy that the speed in which I completed this has improved. It was a good challenge to continue to build upon my base knowledge.
What challenges did you encounter, and how did you overcome them?I don't feel like I encountered many problems with this one.
What specific areas of your project would you like help with?I used a switch statement to handle the button clicks. Is there a better way?
@MattJM1007Posted 8 months agoHi Nate!
First off, amazing job with this project, I can see it is nearly identical to the design. Really well done. looks amazing!
As far as the button clicks, I am not sure myself what a switch statement is, but here is how I achieved the result in my css:
button:hover{ background-color: hsl(75, 94%, 57%); color: hsl(0, 0%, 8%); cursor: pointer; }This is a hover state property where you can change the look of the element your are hovering over. Hope this helps!
Marked as helpful0 - @889-djSubmitted 8 months ago@MattJM1007Posted 8 months ago
Great work on completing this! The layout of everything looks great.
A couple small details, the title of the blog should be black and the hover state is yellow, it looks like you just have it set to the yellow color.
For the description text, it should be the light gray. I also found out that you can adjust the line height of this to better match the design. I used
line-height: 1.5;in my solution.I'll also pass on feedback I received about html, which is to use more specific tags, like
<main>,<article>,<footer>, etc. This helps with accessibility from my understanding. So for example you could replace the '<div class="card">' with '<main>' in your code.Great job!!
0 - @002karanSubmitted 8 months ago@MattJM1007Posted 8 months ago
Great job completing the work! looks like some of the fonts and body color text is off. I would double check that. Also the spacing is off between the two texts, I would check the margins
Marked as helpful0
