Skip to content
OverviewSolutions
9
Comments
4
Martin Eichinger
@MartinEichinger

All comments

  • Martin Eichinger•380
    @MartinEichingerPosted over 2 years ago

    Hi Khoi,

    I like your solution very much. I think it is quite perfect. I only find one point I would like to share with you. On bigger screens the first image on the main page is getting to big for my opinion. You may limit it to the size of a 1440px screen by setting the max-width of the picture to 1440px (center it with margin 0 auto and giving the above section the right shade of black).

    Best regards, Martin

    Marked as helpful
    0
  • cooper•70
    @Coops023Submitted over 2 years ago

    I found the overall page designs not so difficult, however i had some issues with the cart and i went off design a bit to implement the stripe api for real payement's, this i found quite difficult and it is not currently working as i would like. any feedback appreciated

    React, redux, node, express, mongoDb, stripe api

    2
    Martin Eichinger•380
    @MartinEichingerPosted over 2 years ago

    Hi Cooper,

    I also think the design is already quite good. I found some smaller topics, which I would like to share with you:

    • Viewing the website on bigger screens > 1600px, the website gets a little out of joint. To solve that you could limit the max-width of your body to e.g. 1440px.
    • Using the same web font (> manrope) and also the exact same sizing of headings and paras would give the design a bit more perfect look

    Bests, Martin

    0
  • Martin Eichinger•380
    @MartinEichingerPosted over 2 years ago

    Hi Sola,

    I think the design already looks really good. I found some smaller topics, which I want to share with you:

    • On bigger screens your header, footer and some of the content loose a good position. I would recommend to use max-width on the content container, so that the size of your content could never be greater than e.g. 1280px
    • If you like to follow the design in a perfect way the background color of your site should be set to that light yellow color of the design
    • In the footer the logos could be a bit greater (24 x 24px instead of 14 x 14px)

    Cheers, Martin

    Marked as helpful
    0
  • Martin Eichinger•380
    @MartinEichingerPosted over 4 years ago

    Hi Micky, many thanks for your feedback. I tried the change for max-width and margin: auto. I think this works, but I there is another problem as I use extensively "vw" for auto-sizing the font-size, which is not stopped by max-width. Maybe I have to rethink this auto-sizing of the font-size.

    With the HTML issue I don't really understand the problem as the google fonts should be implemented correctly -> <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,600,700|Poppins:400,700&display=swap" rel="stylesheet"> ?

    Cheers!

    0