Responsive design / HTML / SCSS / flexbox

Community feedback

• 

  T

  Mike Hayden•1,005

  @mickygingerPosted over 4 years ago

  Hey Martin, this is great!

  Make sure you add a max-width your content as at the moment the design will stretch to the fill width of the screen. I'm using quite a wide monitor, and it is huge! 😜

  If you look at this site we have a .container class which has a max-width of 1200px for desktop screens, so that the site never gets too stretched out. We also use margin: auto to make sure the content is centered on large screens (this can also be achieved with flex).

  It's also a good idea to look at your report above 👆. You have a few HTML and accessibility issues that, if you fix will look good on your portfolio.

  Well done, and keep up the good work! 🎉

  1
• 

  Martin Eichinger•380

  @MartinEichingerPosted over 4 years ago

  Hi Micky, many thanks for your feedback. I tried the change for max-width and margin: auto. I think this works, but I there is another problem as I use extensively "vw" for auto-sizing the font-size, which is not stopped by max-width. Maybe I have to rethink this auto-sizing of the font-size.

  With the HTML issue I don't really understand the problem as the google fonts should be implemented correctly -> <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,600,700|Poppins:400,700&display=swap" rel="stylesheet"> ?

  Cheers!

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @MartinEichinger this StackOverflow Q&A should help you out, Martin 👍

  0