Skip to content
OverviewSolutions
7
Comments
7
Manisha3196
@Manisha3196

All comments

  • Manisha3196•120
    @Manisha3196Posted 18 days ago

    Hi.For the name i think headings tag will suit better and testimonial text i think p tag suits better than div. I think you used the style for name and graduate in HTML but you can style it in directly in css style so that you will not be repeating the code again and again in HTML. I think you used divs more than you want.you can try checking out other HTML tags like h1,h2,h3 or section or p or article tags. It is not responsive page as you used fixed div tags.rather that you can wrap each one of the testiomonial in div and use flex for mobile and then use grid to arrange the testimonial cards.It will be more responsive and efficient.

    1
  • Manisha3196•120
    @Manisha3196Posted 24 days ago

    Hi @marliedev,Your code looks clean and readable.

    0
  • Brian Meinert•170
    @bmeinert8Submitted 24 days ago
    What are you most proud of, and what would you do differently next time?

    The thing that I'm most proud of in this project is the customization that I added to the project. I believe that customizing each and every one of these projects with your own ideas is a true challenge in itself, that really helps push the project to the next level. These challenges take time and skill as it is, but to be able to really make it your own, implement your ideas, and see the finished product come to life, is where the fun is at for me!

    What challenges did you encounter, and how did you overcome them?

    The biggest challenge I had in the project was getting the JS feature to work. I'm fairly new to JS at this stage still so doing a lot of googling, youtubing, and trial and error to get the cart function working was a big obstacle at first for me, but also very fun learning experience and overly satisfying to see completed and working.

    What specific areas of your project would you like help with?

    Full on code review. Let me know what can be cleaned up, better organized, and just all around any detailed suggestions you can possibly leave me with to help make me a better programmer. As always, thanks for looking and taking the time, it's truly appreciated :)

    Responsive preview card with JS cart feature

    1
    Manisha3196•120
    @Manisha3196Posted 24 days ago

    I think your code looks clean and readable.kudos to you for customizing your own ideas. Suggestions that i can give as iam still new to this are

    • picture tag for product-image in HTML. <picture> <source srcset="./images/image-product-desktop.jpg" media="(min-width: 800px)" /> <img src="./images/image-product-mobile.jpg" alt="perfume-image" /> </picture>

    So that it selects image according to width.

    -maybe try to use grid maybe.I think it is more efficient.

    I would also like to know how did you get to know the that precise image/margin width and height in rem like .212rem.Is that all trial and error or else is there any other way you did it.

    Marked as helpful
    1
  • Manisha3196•120
    @Manisha3196Posted 25 days ago

    Hi, Your code looks clean and readable.for the line border-bottom maybe u=you can use the color stone150 given in style.md. Also for class instructions maybe you can play with margin or padding so that the li items will start at same place for every line.

    0
  • Boffdub•60
    @BoffdubSubmitted 28 days ago
    What are you most proud of, and what would you do differently next time?

    I was able to make it responsive. I've always put it off in the past but it wasn't as scary as I thought it would be.

    These challenges have been easier too.

    What challenges did you encounter, and how did you overcome them?

    I was trying to figure out if it was a or an tag. I tried it both ways and the tag ended up making more sense given the screenshot I was given.

    What specific areas of your project would you like help with?

    If there are ways to clean up the code a bit.

    Social Links with HTML & CSS with Responsive Design

    1
    Manisha3196•120
    @Manisha3196Posted 28 days ago

    Hi, I think you code looks clean and readable.

    1
  • Manisha3196•120
    @Manisha3196Posted 28 days ago

    Hi @dhimanharsh, I think your solution looks good but for the height maybe you can use min-height: 100vh in body style.It really helped me.

    0
  • Eduardo Santos Ferreira•10
    @eduardo5010Submitted 28 days ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of building the modern design provided by Frontend Mentor, and I would differently do the css attributes for the design.

    What challenges did you encounter, and how did you overcome them?

    I had difficulty at working with git on syncing my repository changes when working on this project, I think I need to learn more about it. I overcome by adding a new branch with the modified archives and deleting the previous main branch.

    What specific areas of your project would you like help with?

    I would like help with how to organize the HTML tags to get a more beautyful design and help with knowing more tags to use and CSS attributes to use when coding.

    QR Code Card

    1
    Manisha3196•120
    @Manisha3196Posted 28 days ago

    I think instead of px for margin try rem's maybe it will help in more in adjusting the margin and padding. It really helped me. I think you don't need another div tag for text because its a simple qr-code with text using different HTML tags that you can access it directly and you dont need to specially put it in grid or flexbox to style the text but its just my opinion.

    Marked as helpful
    1