Skip to content
OverviewSolutions
10
Comments
5
Samia Mahwash
@Mahwash-Aly

All comments

  • Samia Mahwash•170
    @Mahwash-AlyPosted almost 3 years ago

    Hi Dusviry! Your solution looks perfectly fine to me. Keep up the good work. :)

    0
  • Samia Mahwash•170
    @Mahwash-AlyPosted almost 3 years ago

    Your mobile view looks good. Desktop view has some issues. First, you need to change the background colour of section-1. Also, p tag in section-1 needs margin and padding as it should be on multiple lines. Otherwise, it's a nice try.

    Marked as helpful
    0
  • Samia Mahwash•170
    @Mahwash-AlyPosted almost 3 years ago

    Hey Mohammad, Your Desktop version looks good but mobile view needs improvement. In responsive mode, all the space below the learn more button disappears and everything squeezes. Also, please check border-radius of top and bottom cards in mobile view. Otherwise it's a nice try!

    0
  • Samia Mahwash•170
    @Mahwash-AlyPosted about 3 years ago

    Hey nice work. You can improve the look by adding paragraph color: hsl(229, 6%, 66%) as shown in the design.

    Marked as helpful
    1
  • Sheelove Dol•150
    @SheeloveDolSubmitted about 3 years ago

    Just finished my second project from this awesome website. While I'm proud I got it done, I still come away feeling like somethings are amiss. That being said the functionality part seems to be working. Any feedback is greatly appreciated.

    Mobile first using CSS Grids with flexbox

    3
    Samia Mahwash•170
    @Mahwash-AlyPosted about 3 years ago

    Nice Try! I myself just attempted this challenge. About the second point that CyrusKabir mentioned, you can use in body is: display: flex; align-items: center; justify-content: center; height: 100vh;

    This should solve the issue of centering container.

    Marked as helpful
    1