@pikapikamart
Posted
Hey, great work on this one. Layout in desktop looks great, though the responsive state could be better since when changing the screen's width, the button
gets distorted. The mobile layout however looks really great.
You already got great feedback from others and is really great. Just going to add some quick suggestions:
- You don't need to use
section
to wrap each card since they all are related to one another, if you are going to usesection
use it to wrap the whole 3 cards since it is a "section" of card-colllections. - Always have a
h1
on a page. Since there is no visible text that could be a heading tag, you will need to make theh1
screen-reader only. Meaning it will be usingsr-only
class. Have a look at Grace's solution on this one inspect the layout and see how she used theh1
, copy also the styling on it, you will use that a lot. - Each
img
should be hidden since they are just decorative images. So you need to usealt=""
and extraaria-hidden="true"
attribute on it. Decorative image should be hidden at all times. - Also, there are lots of
div
wrapping every content, you don't really need those lots, you could remove them^^
Aside from those, really great work on this one again.
Marked as helpful