P
@AdamullaOsasSubmitted 6 months ago
Latest comments
- @Mageshwari-BalaguruPosted 6 months ago
it is perfect , responsive website. i actually don't know scss. I've heard about this. could you suggest some tips since i'm a beginner.
0 - @arsh-deSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I was able to use JS
What challenges did you encounter, and how did you overcome them?Try to get the position for the share button content, but I unable to make that small arrow.
What specific areas of your project would you like help with?How to make that small arrow.
@Mageshwari-BalaguruPosted 8 months agoHi
Congratulations for completing the challenge! I don't know about tailwind CSS - However, when i click preview site i couldn't see your styles and Js renders on the page. I checked the link element in HTML that was Okay. I am not able to find where the issue was.
I checked the Js file and the logic is good. it should display the content when the button was clicked.
0 - @MYM200519Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
"I think I did a good job as a newbie."
What specific areas of your project would you like help with?Any help is welcome!
@Mageshwari-BalaguruPosted 8 months agoHi, Congratulations on completing the challenge!.
Overall the code done its job. using flex for centering the container is good. There is no repetition in your code. I like the code.
I've some suggestion,
- Use semantic HTML elements - header, main, section, footer
- in the <img> tag, give appropriate alt content.
0 - @sweatylolzSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I got it looking very similar the design with a lot more ease than I thought.
What challenges did you encounter, and how did you overcome them?I did get some challenges with flexbox and getting it to work as desired. But once I figured out the dynamics it was very useful.
What specific areas of your project would you like help with?Importing google fonts
@Mageshwari-BalaguruPosted 8 months agoHi, congratulations on completing the challenge! Importing google fonts - we can import google fonts in two ways. we can add link to our HTML head tag or import at CSS file.(Recommended one is adding to HTML head ) add these lines to your HTML head
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap" rel="stylesheet">``` Steps: 1. Google - type google fonts search 2. to the first search list - type your desired font name and search 3. Click get font 4. Click get embed code 5. you can see two links over the right side. (copy and paste as your wish) I've some suggestions to your code. 1. include HTML semantics (header,main,footer) 2.you don't need to mention all the child elements to display:flex; its already in a flex-container. Thanks. happy coding! :)0 - @CraowxSubmitted 8 months ago@Mageshwari-BalaguruPosted 8 months ago
Hi, I've viewed your site. Responsive, same like the design. :) If i able to view your code i can boost my skills.
Thanks.
0 - @bobyanovSubmitted 8 months ago@Mageshwari-BalaguruPosted 8 months ago
Hi, congratulations on completing the challenge :) I have some suggestions.
- Avoid unwanted indentations - try to use prettier Extension in Vs code.
- Avoid using Pixel/percentage values for all the attributes which is hard constraint for flex/grid layout. try to use unit values ems/rems. 3.Missing of semantic elements. - Kindly google it to know its importance.
- Try to use Grid Layout to center the child elements which will reduce the size of the code.
I hope this will help!
Thanks. Magi :)
Marked as helpful0
