P
Emilia Burza• 230
@eburza
Submitted
Ecu
@Maflacs
All comments
- Ecu• 220
@Maflacs
Posted
Great job!
One thing I noticed is that the logo isn't displaying. I suggest trying the following code:
<img id='logo' src='/images/logo.svg' alt='splitter logo' />Also, when the "Number of People" value is 0, the user doesn't receive any feedback. The sample design suggests a red border and a red error message for this scenario.
Wishing you the best of luck and perseverance with your future work! :)
0 - Juan• 480
@JEWebDev
Submitted
What are you most proud of, and what would you do differently next time?
Im proud that i was able to finish the challenge and was able to fill the data with the json file included. Also used css grid this time
What challenges did you encounter, and how did you overcome them?
Most of the things that i needed i had made them before, like the radio button nav for the timeframes was similar to the one in the tip calculator app so it was easier, also using the json was easier too because i already did it in the results summary challenge. It feels nice to see and feel that i am making a progress
What specific areas of your project would you like help with?
Any feedback is welcomed.
Ecu• 220@Maflacs
Posted
Nice work! What I noticed is missing are the radio inputs and the '...' hover effect. Keep up to good work!
0 - JamesYcode• 140
@JamesYcode
Submitted
What are you most proud of, and what would you do differently next time?
I was of the CSS portion alongside the JavaScript functionality. Working with DOM manipulation has reminded me the fundamentals of vanilla JavaScript. If I were to redo this which I might do some refactoring later on, I would structure my code in a non hacky way.
What challenges did you encounter, and how did you overcome them?
One challenge I came across was the fundamentals of JavaScript. Form validation was something I hadn't done in a long time. I overcame it by researching form validations and instead of copying and pasting, I broke the problems down into small components on what I wanted to achieve, in this case was the input validations.
What specific areas of your project would you like help with?
I realized at the end that the responsiveness was not what I had intended. The width of the container alongside the contents within are breaking at a smaller viewport. Another problem I encountered was the hacky way of manipulating the DOM with JS and CSS for the form validations.
Ecu• 220@Maflacs
Posted
Nice work, but in mobile view, the p and h1 elements of the confirmation window are not readable due to the background color of the container. Keep up the good work! :)
Marked as helpful
1 - Shivangam Soni• 970
@ShivangamSoni
Submitted
Ecu• 220@Maflacs
Posted
It looks good, but some of the images have a slight border. :)
1 - merveuluser• 40
@merveuluser
Submitted
Ecu• 220@Maflacs
Posted
It looks good, but perhaps the container could have a little margin at the top and bottom to better resemble the original :)
0
