All comments

• 

  Santiago-Parra22•10

  @Santiago-Parra22Submitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  I am proud of everything I learned from doing this first challenge. I feel that I have acquired too much knowledge, that it would be better to focus on finding an optimal solution and let myself be guided by those who have more knowledge.

  What challenges did you encounter, and how did you overcome them?

  The challenge of placing the image within the same container as the letters will be overcome after several hours of research.

  What specific areas of your project would you like help with?

  At the moment I feel that I am not that bad in knowledge, but any help will be well received.

  

  Responsive landing page

  1

  40
  

  P

  MJDFreelance•10

  @MJDFreelancePosted 6 months ago

  Well done, this looks good for your first submission.

  A couple of notes;

  1. Your background color is incorrect. This was provided in the style guide, so is important to get right. I see you are using tailwind, so it's a good practice when you start a project to move anything from the style guide into your tailwind config. This way it will always be available wherever you are within the project.
  2. For accessibility it is important that alt tags contain a descriptive value. The entire point of the page is to display this QR code. If someone comes to the page who is visually impaired, they may miss this and so miss the whole point of the page. A short but descriptive alt such as 'QR code for Frontend Mentor' would be really helpful for them.

  Otherwise good work!

  0