Skip to content
OverviewSolutions
38
Comments
20
Luis Herrera
@Luis15Herr

All comments

  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Very good work! I recommend you read about the bem methodology. Currently your scss code looks like this, example:

    .main{

   div1{

       div2{

           div3{

           }

        }

    }

}

    With the bem methodology you maintain the specificity of your classes, making it much easier to maintain the code.

    Example of bem metodology with sames clases from above:

    .main{...}

.main__div1{...}

.main__div2{...}

    This way it will be much easier for you to make your css code :)

    Marked as helpful
    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    You can use a regex expression to validate the email and show the error :)

    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Buen día amigo, muy buen trabajo para ser tu primera practica.

    En el path de tu imagen, te hace falta un punto para especificar tu ruta.

    actualmente lo tienes asi : <img src="/images/image-qr-code.png" class="img__qr">

    Y deberias tener un punto por delante: <img src="./images/image-qr-code.png" class="img__qr">

    Saludos :)

    Marked as helpful
    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Amazing work :)

    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    The cart icon is in the ./images folder.

    Marked as helpful
    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Hello, you could use a:

    background-size: cover;

    In your class: .card--img

    So that the background-img of your div: fills all the free space.

    Marked as helpful
    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Someone knows why the font in the screenshots is a little lower than the webpage?

    0
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the URL shortening API landing page.

    I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.

    I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!

    Thanks

    URL shortening API landing page

    14
    Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Amazing Work :)

    0
  • Luis Herrera•795
    @Luis15HerrPosted over 2 years ago

    Hi, you can do it with display flex c:

    You just have to give a height of 100% to your body tag and html tag and the align-item:center will work; what do you have c:

    Marked as helpful
    1
  • Luis Herrera•795
    @Luis15HerrPosted almost 3 years ago

    Good job :)

    1
  • Luis Herrera•795
    @Luis15HerrPosted almost 3 years ago

    Good Job Bro :)

    Marked as helpful
    0
  • Luis Herrera•795
    @Luis15HerrPosted almost 3 years ago

    Why do you ask for feedback if you are going to delete the solution where the feedback was given? xDDDD

    1