Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • NBD• 240

    @bdal90

    Submitted

    Dear All,

    Here is my 2nd, i.e. second project ever created and I am open to all kinds of suggestions and criticisim. Honestly, the task was much harder than I thought it would be and even though the result seems okay at first sight, the detailes feel a little bit messy and I don't know how to be more organised in my coding. I guess my main concerns were the following:

    1.) I'm not sure about how to name the HTML classes. I was trying to follow some kind of pattern, but the whole thing just ended up rather clumsy. 2.) By the end, I felt like I had a whole lot of random things in CSS, I'm absolutely sure I could not follow the DRY concept, how could I have been more effective? What are the key elements I should pay attention to? 3.) This is my very first attempt of making the project responsive, but I think it is kind of messed up as the image collapses way before 370px width. What did I do wrong? 4.) I really would like to deal with the JSON part and I also know the JavaScript for that, I just don't know how to START! Any hints maybe?

    Thank you in advance for checking it out,

    Wishing us all fun practicing,

    Dalma

    P
    Joska• 500

    @LowkeyCoyote

    Posted

    Hello NBD !

    Congratulations !

    Great project, the design looks really good!

    I'll try to answer some of your questions :)

    1 The class names must be explicit, and not ambiguous. You can also limit the use of classes by using css selectors. For example in your code, the h1 element has a class. Whereas you could do without it by selecting it directly. h1{ font-size:..}

    3 There is this effect between 370px width (your breakpoint) and 480px, since the width of the card ( The element with the .project classe ) is fixed at 480px on Desktop. One way to remedy this would be to use a higher breakpoint, 500px for example.

    Also, don't forget the alternative text for images, for accessibility reasons

    I hope you found my post useful

    Good Coding :)

    Marked as helpful

    0
  • Francis Wen• 10

    @FrancisWen117

    Submitted

    I'm still learning how to make a proper responsive website using html and css. This project is made by only two things (HTML and CSS) I know. I didn't designed for responsive layout since I don't feel like the project is simple. It would be better if you can check it out and tell me my errors and how to make a better version. Thanks

    P
    Joska• 500

    @LowkeyCoyote

    Posted

    Hello !

    Great work !

    few remarks

    • You can look at the HTML report to correct accessibility and HTML issues.
    • You can change the name of certains class in order to make it more lisible. For example, in your code, there is plan, plan1, plan2 etc ...

    I hope this is helpful, good luck ! :)

    0
  • P
    Joska• 500

    @LowkeyCoyote

    Posted

    Hello !

    Great work !

    You can look to the HTML report to correct accessibility :)

    I hope this is helpful, good luck !

    0
  • @catherineisonline

    Submitted

    Hello, Frontend Mentor community! This is my solution to the Testimonials grid section.

    I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.

    You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.

    Thank you

    P
    Joska• 500

    @LowkeyCoyote

    Posted

    Great work !

    0