Joska
@LowkeyCoyoteAll comments
- @bdal90Submitted over 1 year agoP@LowkeyCoyotePosted over 1 year ago
Hello NBD !
Congratulations !
Great project, the design looks really good!
I'll try to answer some of your questions :)
1 The class names must be explicit, and not ambiguous. You can also limit the use of classes by using css selectors. For example in your code, the h1 element has a class. Whereas you could do without it by selecting it directly. h1{ font-size:..}
3 There is this effect between 370px width (your breakpoint) and 480px, since the width of the card ( The element with the .project classe ) is fixed at 480px on Desktop. One way to remedy this would be to use a higher breakpoint, 500px for example.
Also, don't forget the alternative text for images, for accessibility reasons
I hope you found my post useful
Good Coding :)
Marked as helpful0 - @FrancisWen117Submitted about 3 years agoP@LowkeyCoyotePosted about 3 years ago
Hello !
Great work !
few remarks
- You can look at the HTML report to correct accessibility and HTML issues.
- You can change the name of certains class in order to make it more lisible. For example, in your code, there is plan, plan1, plan2 etc ...
I hope this is helpful, good luck ! :)
0 - @BantamaSubmitted about 3 years agoP@LowkeyCoyotePosted about 3 years ago
Hello !
Great work !
You can look to the HTML report to correct accessibility :)
I hope this is helpful, good luck !
0 - @catherineisonlineSubmitted about 3 years ago