Skip to content
OverviewSolutions
2
Comments
2
Matías Fuentes
@LeoCaprile

All comments

  • Matías Fuentes•50
    @LeoCaprilePosted almost 3 years ago

    I don't know what file arquitecture you used, but it's really difficult to understand your code, You are using react like a template engine and react is not a template engine. So try to make more components and add individuality by doing more components. Read about the different type of arquitectures there are. The final result is Nice, but if we talk about escalabilty, i would re made the arquitecture. I Say, always go for redability of your code. Very good job!

    0
  • Ngoc Anh Vu-Martell•125
    @anh-vumartellSubmitted almost 3 years ago

    I have a few concerns while developing this app.

    1. How to change color of svg icon? The color of cart icon in "Add to cart"-button should be white but mine is gray.
    2. On hovering thumbnails, the border appears a weird way. A black border quickly appears before the real border color. This also happens on hovering user avatar icon. Any comments on this behavior?
    3. I haven't really find out how to pass data from my imgSlide-context to the <Modal/> component. For now the current image in modal is default the first image in image array (dataImg.jsx). Any suggestions on how to implement this final feature of my app. Thank you for your time. Cheers,

    Responsive ecommerce product page in React and Sass

    2
    Matías Fuentes•50
    @LeoCaprilePosted almost 3 years ago

    Hi! I loved the popup notifications, I help you with your concern about change color to a svg, in css you hace a property called "fill" this one can change the color of a svg.

    1