Skip to content
OverviewSolutions
8
Comments
3
Mobile_Koda
@Lemon-stack

All comments

  • JimTK16•370
    @JimTK16Submitted 12 months ago

    I'm a newbie so would really appreaciate if you can share some other sources that you use to hone your front end skills ?

    QR code component - HTML CSS

    2
    Mobile_Koda•140
    @Lemon-stackPosted 12 months ago

    Great job🌟 Just keep up on frontend mentor's challenges, its a great practice platform. You could also do other recommended frontend projects too. The design you rendered is almost the same as the normal design. Just have to set the border of the .container to none to remove the black line around the component. i.e .container{ border:none; }

    1
  • Diksha Bhat•10
    @Diksha192001Submitted 12 months ago

    • I am not sure if i did the prefered/correct way for keeping a square inside a rectangle. Can anyone please check?

    • And also in general tell me if there are any major beginner mistakes that i have done, which could have been avoided or done in a better way.

    Desktop QR Code Solution using HTML and CSS

    2
    Mobile_Koda•140
    @Lemon-stackPosted 12 months ago

    You did good👍 Here's what I think : • You didn't had to necessarily upload all the work files, they were for guidance. Only your HTML, CSS and image files would do. • Giving a class and setting it's background-image wasn't really necessary, you could have just included your image tag and adjust the width and height settings. Apart from that.... your solution was 🎯 I hope you found this helpful 😊.... Happy Coding 🌟

    Marked as helpful
    1
  • Mobile_Koda•140
    @Lemon-stackPosted 12 months ago

    Congratulations on the completion of this challenge project👍 Heres some areas i think should be noted in your code : 🎯 consistency in your attribute and property declaration: for example, in your image, you declared the border radius as...

    .image{ border-top-left-radius: 15px; border-top-right-radius: 15px; border-bottom-left-radius: 15px; border-bottom-right-radius: 15px; margin-bottom: 20px; } Which could be also be written In its shorthand property as :

    .image{ border-radius: 15px; } 🎯 more important to note that, in small projects like this, you don't really need to give the image a class. It could be declared like this :

    img{ border-radius: 15px; } Hope you found this helpful😊 Either ways... Choose what works for you 🌟

    0